Skip to content

make comments match the code in secure channel implementation - #1198

Merged
jbenet merged 1 commit into
ipfs:masterfrom
dominictarr:master
May 6, 2015
Merged

jbenet merged 1 commit into
ipfs:masterfrom
dominictarr:master

Conversation

@dominictarr

Copy link
Copy Markdown
Contributor

Reviewing the secure channel I noticed some places where the comments said something different to what the code did. I have fixed the comments to match the code.

The first thing was in the cipher selection step, the comments said cmp(hash(lr || rpub), hash(rr || lpub))
but the code joined those the other way around. Also there was a spot later on where an earlier comment had been copypasted from before, and didn't make sense anymore.

I also noticed a few small improvements that could be made to the cipher selection process, but will post another issue.

@jbenet jbenet added the backlog label May 6, 2015
@jbenet

jbenet commented May 6, 2015

Copy link
Copy Markdown
Member

LGTM, thanks @dominictarr

jbenet added a commit that referenced this pull request May 6, 2015
make comments match the code in secure channel implementation
@jbenet
jbenet merged commit 5463331 into ipfs:master May 6, 2015
@jbenet jbenet removed the backlog label May 6, 2015
@jbenet jbenet mentioned this pull request May 9, 2015
9 of 36 tasks
@aschmahmann aschmahmann mentioned this pull request Dec 1, 2021
79 of 80 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants