Skip to content

mild refactor of bitswap - #1199

Merged
jbenet merged 2 commits into
masterfrom
feat/bsrefactor
May 6, 2015
Merged

jbenet merged 2 commits into
masterfrom
feat/bsrefactor

Conversation

@whyrusleeping

Copy link
Copy Markdown
Member

This is a mild cleanup of bitswap to remove some unused code and return errors from a few more functions because i hate not returning errors when i am able to. Functionally, nothing is changed.

I also removed a test from exchange/bitswap/testnet that was testing unused code.

@whyrusleeping whyrusleeping added the status/in-progress In progress label May 6, 2015
Comment thread exchange/bitswap/bitswap.go Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this error probably should not be returned by ReceiveMessage, but logged or otherwise handled. AFAIK, if this fails, it does not mean a ReceiveMessage failure.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(agree with the general sentiment of not hiding errors, but incorrect errors aren't good either)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hrm, alright

@jbenet

jbenet commented May 6, 2015

Copy link
Copy Markdown
Member

github's complaining. looks like it needs a rebase?

jbenet added a commit that referenced this pull request May 6, 2015
@jbenet
jbenet merged commit 0d521ff into master May 6, 2015
@jbenet
jbenet deleted the feat/bsrefactor branch May 6, 2015 09:31
@jbenet jbenet removed the status/in-progress In progress label May 6, 2015
@jbenet jbenet mentioned this pull request May 9, 2015
9 of 36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants