Skip to content

feat(docker) build a daemon - #250

Merged
jbenet merged 1 commit into
masterfrom
docker-daemon
Nov 2, 2014
Merged

jbenet merged 1 commit into
masterfrom
docker-daemon

Conversation

@btc

@btc btc commented Nov 2, 2014

Copy link
Copy Markdown
Contributor

@jbenet Quick change.

The default Docker build now creates a daemon without mounting.

TODO allow bootstrap node to be overridden at runtime (perhaps with an
environment variable), so we can use custom topologies in test
environments. NB: We still want the default behavior to connect to Mars.

TODO create a docker image that mounts (and uses shared volume to make
that mount accessible on the host).

The default Docker build creates a daemon.

TODO allow bootstrap node to be overridden at runtime (perhaps with an
environment variable), so we can use custom topologies in test
environments. NB: We still want the default behavior to connect to Mars.

TODO create a docker image that mounts and uses shared volume to make
that mount accessible on the host.
@btc btc added the status/in-progress In progress label Nov 2, 2014
jbenet added a commit that referenced this pull request Nov 2, 2014
@jbenet
jbenet merged commit 07e55fc into master Nov 2, 2014
@jbenet
jbenet deleted the docker-daemon branch November 2, 2014 00:39
@jbenet

jbenet commented Nov 2, 2014

Copy link
Copy Markdown
Member

πŸ‘

@jbenet jbenet removed the status/in-progress In progress label Nov 2, 2014
@whyrusleeping

Copy link
Copy Markdown
Member

IPFS_BOOTSTRAP="/ip4/1.2.3.4/tcp/4001"

@jbenet

jbenet commented Nov 2, 2014

Copy link
Copy Markdown
Member

IPFS_BOOTSTRAP="/ip4/1.2.3.4/tcp/4001"

+1. or --bootstrap

Maybe we should have an cmd/ipfs/env.go that defines all the things that command will take.

@btc

btc commented Nov 2, 2014

Copy link
Copy Markdown
Contributor Author

@jbenet

+1 --bootstrap might be better. That way makes it easier to include multiple bootstrapping nodes.

ipfs -d --bootstrap /ip4/foo --bootstrap /ip4/bar

@jbenet

jbenet commented Nov 2, 2014

Copy link
Copy Markdown
Member

-1 on multiple flags like that. that complicates commands package and is ambiguous depending on interpretation. is it an array? is it an overridden string?

I filed multiformats/multiaddr#5 to think of a good way to represent multiaddrs in a set.

@btc

btc commented Nov 2, 2014

Copy link
Copy Markdown
Contributor Author

Fair. One bootstrap node for now is fine by me.

ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this pull request Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants