Skip to content

Build: Fix Makefile on Windows - #2975

Merged
whyrusleeping merged 2 commits into
ipfs:masterfrom
djdv:makefile-win-fix
Jul 18, 2016
Merged

whyrusleeping merged 2 commits into
ipfs:masterfrom
djdv:makefile-win-fix

Conversation

@djdv

@djdv djdv commented Jul 16, 2016 •

Copy link
Copy Markdown
Contributor

This request brings back in a reverted commit with a fix on top for platform delimiters.
Before this gets merged though I would like people to test it on various systems, it works for me in msys2 where it did not originally, but I only use a single GOPATH. If anyone could try building with this and report on the results I'd appreciate it.

@ChristianKniep
Could you run this and see if you have any build issues? (In relation to #2969)

@jefft0
Could you run this inside of Cygwin? I'm not sure if Cygwin will get picked up as Windows or not with this condition.

karalabe and others added 2 commits July 16, 2016 18:06
License: MIT
Signed-off-by: PΓ©ter SzilΓ‘gyi <peterke@gmail.com>
License: MIT
Signed-off-by: Dominic Della Valle <ddvpublic@gmail.com>
@djdv
djdv force-pushed the makefile-win-fix branch from 5b0e4c8 to 228c4db Compare July 16, 2016 22:40
@ghost

ghost commented Jul 17, 2016

Copy link
Copy Markdown

@djdv thanks so much for taking this on! :) I'll give it a try with docker tomorrow!

@djdv

djdv commented Jul 17, 2016 •

Copy link
Copy Markdown
Contributor Author

I went ahead and tested on Cygwin with a single GOPATH, it built fine, so no breakage there at least. Not sure about multiple paths though.

@lgierth Looking forward to seeing the results, I didn't want @karalabe's patch to disappear since it worked on *nix systems originally.

@jefft0

jefft0 commented Jul 18, 2016

Copy link
Copy Markdown
Contributor

make install works for me on Cygwin. Thanks.

@ChristianKniep

Copy link
Copy Markdown
Contributor

@djdv Works for me now, thanks!

@karalabe

Copy link
Copy Markdown
Contributor

Works for me too πŸ‘

PS: Sorry for not reacting till now, we're having a bit of a crisis at Ethereum for the last month or so.

@whyrusleeping

Copy link
Copy Markdown
Member

LGTM, thanks everyone!

@whyrusleeping
whyrusleeping merged commit 0e4c195 into ipfs:master Jul 18, 2016
@djdv
djdv deleted the makefile-win-fix branch July 18, 2016 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants