Skip to content

Cleanup makefiles - #2999

Merged
whyrusleeping merged 6 commits into
masterfrom
feature/makefile-cleanup
Aug 16, 2016
Merged

whyrusleeping merged 6 commits into
masterfrom
feature/makefile-cleanup

Conversation

@Kubuxu

@Kubuxu Kubuxu commented Jul 27, 2016

Copy link
Copy Markdown
Member

This can wait for after release but it shouldn't affect the release in any form either.

We might want to limit number of threads on the sharness or make output sequential of sharness because now they run in parallel.

@Kubuxu
Kubuxu force-pushed the feature/makefile-cleanup branch from ebb32f2 to 8a299fa Compare July 27, 2016 15:51
Comment thread test/Makefile Outdated
clean:
rm $(BINS)
$(MAKE) -C sharness clean
-rm -rf $(BINS)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's -rm doing?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- prefix makes make ignore return code of rm command.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay then I think it's not needed -- -f makes it ignore non-existing files/dirs anyhow

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I should clear it up everywhere.

@ghost

ghost commented Jul 27, 2016

Copy link
Copy Markdown

LGTM apart from one question ^

@atomgardner

Copy link
Copy Markdown
Contributor

You can squash these:

build install nofuse: deps
        $(MAKE) -C cmd/ipfs $@

clean uninstall:
        $(MAKE) -C cmd/ipfs $@

And if we could drop "deps" as a prerequisite here (it is serious overkill), all 5 options could be squashed into two lines.

@Kubuxu

Kubuxu commented Jul 28, 2016 •

Copy link
Copy Markdown
Member Author

@thomas-gardner that is awesome trick, Thanks,

but we can't drop the deps.
and the second one isn't really squashable.

@whyrusleeping

Copy link
Copy Markdown
Member

@Kubuxu wanna go ahead and rebase this on master?

Kubuxu added 6 commits August 4, 2016 16:38
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
@Kubuxu
Kubuxu force-pushed the feature/makefile-cleanup branch from e13bcf8 to cc60f69 Compare August 4, 2016 14:38
@Kubuxu

Kubuxu commented Aug 4, 2016

Copy link
Copy Markdown
Member Author

done

@whyrusleeping
whyrusleeping merged commit f2dcad8 into master Aug 16, 2016
@whyrusleeping
whyrusleeping deleted the feature/makefile-cleanup branch August 16, 2016 17:15
@ghost ghost mentioned this pull request Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants