Skip to content

datastore: blockstore should retry when it encounters temp errors - #3091

Merged
whyrusleeping merged 1 commit into
masterfrom
feat/temp-err-retries
Aug 22, 2016
Merged

whyrusleeping merged 1 commit into
masterfrom
feat/temp-err-retries

Conversation

@whyrusleeping

Copy link
Copy Markdown
Member

This is still a bit of a WIP, i'm not sure if we should inject the retry datastore in core/builder, or in the blockstore constructor.

License: MIT
Signed-off-by: Jeromy why@ipfs.io

License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
@whyrusleeping
whyrusleeping force-pushed the feat/temp-err-retries branch from dcab579 to 8813008 Compare August 16, 2016 18:51
@whyrusleeping whyrusleeping added the need/review Needs a review label Aug 18, 2016
@Kubuxu Kubuxu self-assigned this Aug 18, 2016
@whyrusleeping whyrusleeping added the status/in-progress In progress label Aug 18, 2016
@Kubuxu

Kubuxu commented Aug 20, 2016

Copy link
Copy Markdown
Member

IMO core/builder is good, blockstore is quite general and it shouldn't know about datastore problems.

@Kubuxu Kubuxu removed their assignment Aug 20, 2016
Comment thread core/builder.go
Delay: time.Millisecond * 200,
Retries: 6,
TempErrFunc: isTooManyFDError,
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

take that, disk! πŸ’Ώ

@whyrusleeping

Copy link
Copy Markdown
Member Author

@Kubuxu LGTY?

@Kubuxu

Kubuxu commented Aug 21, 2016

Copy link
Copy Markdown
Member

LGTM

@whyrusleeping
whyrusleeping merged commit 8830aae into master Aug 22, 2016
@whyrusleeping
whyrusleeping deleted the feat/temp-err-retries branch August 22, 2016 16:35
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Aug 22, 2016
@ghost ghost mentioned this pull request Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

need/review Needs a review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants