Skip to content

cmds: implement ipfs dht provide command - #3106

Merged
whyrusleeping merged 4 commits into
masterfrom
feat/cmds/dht-provide
Aug 24, 2016
Merged

whyrusleeping merged 4 commits into
masterfrom
feat/cmds/dht-provide

Conversation

@whyrusleeping

@whyrusleeping whyrusleeping commented Aug 20, 2016 •

Copy link
Copy Markdown
Member

closes #3099

License: MIT
Signed-off-by: Jeromy why@ipfs.io

License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
Comment thread core/commands/dht.go Outdated
path "github.com/ipfs/go-ipfs/path"
routing "github.com/ipfs/go-ipfs/routing"
ipdht "github.com/ipfs/go-ipfs/routing/dht"
"golang.org/x/net/context"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be here.
Maybe we should wait to clear up Go 1.7 situation in #3110

License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
@whyrusleeping

Copy link
Copy Markdown
Member Author

@Kubuxu could I get some review here? Getting this in ASAP will be very helpful

Comment thread core/commands/dht.go Outdated
},

Arguments: []cmds.Argument{
cmds.StringArg("key", true, true, "The key to find providers for.").EnableStdin(),

@Kubuxu Kubuxu Aug 24, 2016 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The key to find providers for."...

License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
Comment thread core/commands/dht.go
})
}

err = dag.EnumerateChildrenAsync(ctx, dserv, node, kset)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to have just a buffered channel here instead of keyset, it looks like dag.FetchGraph could also use it, but it looks like we don't have primitive like that.

This way we could do providing at the same time of fetching recursive graph.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that would be nice. We should make a note to take another look at these interfaces and find better ways to do these things.

License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
@Kubuxu

Kubuxu commented Aug 24, 2016 •

Copy link
Copy Markdown
Member

CI fails.

EDIT: teamcity hit the too many open FD problem.

@whyrusleeping

Copy link
Copy Markdown
Member Author

@Kubuxu i think thats just a messed up build agent, i was working with them yesterday and the failure happened on a new one.

@Kubuxu

Kubuxu commented Aug 24, 2016 •

Copy link
Copy Markdown
Member

Ok, it doesn't look like Travis will run any time in close future but Circle says ok.

LGTM

EDIT: Opps, wrong button.

@Kubuxu Kubuxu closed this Aug 24, 2016
@Kubuxu Kubuxu reopened this Aug 24, 2016
@Kubuxu Kubuxu added the status/in-progress In progress label Aug 24, 2016
@whyrusleeping
whyrusleeping merged commit a2bba21 into master Aug 24, 2016
@whyrusleeping
whyrusleeping deleted the feat/cmds/dht-provide branch August 24, 2016 17:59
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Aug 24, 2016
@ghost ghost mentioned this pull request Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

need/review Needs a review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add ipfs dht provide command

2 participants