Repository navigation
bump go requirement to 1.7 - #3111
Merged
Merged
Conversation
License: MIT Signed-off-by: Jeromy <why@ipfs.io>
License: MIT Signed-off-by: Jeromy <why@ipfs.io>
Member
Author
|
@diasdavid the js-ipfs-api test failures look like an issue on your end. Could you confirm and let me know when there is a fix? |
Member
Author
|
the docker thing needs fixing too, fun. |
Member
|
@whyrusleeping the error is: Because the key we selected to I can update the tests to use some other key, is this decision final with regards to not being able to access Identity from the API? How does the go CLI do it then? Some special whitelisting for go-ipfs cli? |
Member
Author
|
@diasdavid yeah, you can't access anything containing the private key via the api in any way (including the CLI). You could use identity.peerID if you wanted |
Go 1.7 funnily demands gcc for installing gx. License: MIT Signed-off-by: Lars Gierth <larsg@systemli.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI is gonna be fun with this one...
License: MIT
Signed-off-by: Jeromy why@ipfs.io