Skip to content

bump go requirement to 1.7 - #3111

Merged
whyrusleeping merged 3 commits into
masterfrom
feat/go1.7
Aug 26, 2016
Merged

whyrusleeping merged 3 commits into
masterfrom
feat/go1.7

Conversation

@whyrusleeping

Copy link
Copy Markdown
Member

CI is gonna be fun with this one...

License: MIT
Signed-off-by: Jeromy why@ipfs.io

License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
@whyrusleeping whyrusleeping added the status/in-progress In progress label Aug 23, 2016
License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
@whyrusleeping

Copy link
Copy Markdown
Member Author

@diasdavid the js-ipfs-api test failures look like an issue on your end. Could you confirm and let me know when there is a fix?

@whyrusleeping

Copy link
Copy Markdown
Member Author

the docker thing needs fixing too, fun.

@daviddias

Copy link
Copy Markdown
Member

@whyrusleeping the error is:

[19:55:21][Step 3/3]   1) .config callback API .get retrieve a value through a key:
[19:55:21][Step 3/3]      Uncaught AssertionError: expected [Error: cannot show or change private key through API] to not exist
[19:55:21][Step 3/3]       at node_modules/interface-ipfs-core/lib/config.js:39:31
[19:55:21][Step 3/3]       at send (src/api/config.js:28:18)
[19:55:21][Step 3/3]       at Wreck.read (src/request-api.js:46:9)
[19:55:21][Step 3/3]       at finish (node_modules/wreck/lib/index.js:360:16)
[19:55:21][Step 3/3]       at wrapped (node_modules/hoek/lib/index.js:871:20)
[19:55:21][Step 3/3]       at onReaderFinish (node_modules/wreck/lib/index.js:406:16)
[19:55:21][Step 3/3]       at finishMaybe (_stream_writable.js:488:14)
[19:55:21][Step 3/3]       at endWritable (_stream_writable.js:498:3)
[19:55:21][Step 3/3]       at Writable.end (_stream_writable.js:463:5)
[19:55:21][Step 3/3]       at IncomingMessage.onend (_stream_readable.js:512:10)
[19:55:21][Step 3/3]       at endReadableNT (_stream_readable.js:975:12)
[19:55:21][Step 3/3]       at _combinedTickCallback (internal/process/next_tick.js:74:11)
[19:55:21][Step 3/3]       at process._tickCallback (internal/process/next_tick.js:98:9)

Because the key we selected to get on tests was Identity, see:

https://github.com/ipfs/interface-ipfs-core/blob/master/src/config.js#L37-L43

I can update the tests to use some other key, is this decision final with regards to not being able to access Identity from the API? How does the go CLI do it then? Some special whitelisting for go-ipfs cli?

@whyrusleeping

Copy link
Copy Markdown
Member Author

@diasdavid yeah, you can't access anything containing the private key via the api in any way (including the CLI). You could use identity.peerID if you wanted

Go 1.7 funnily demands gcc for installing gx.

License: MIT
Signed-off-by: Lars Gierth <larsg@systemli.org>
@ghost
ghost force-pushed the feat/go1.7 branch from f6823a8 to b84ca68 Compare August 25, 2016 23:44
@whyrusleeping
whyrusleeping merged commit 4594233 into master Aug 26, 2016
@whyrusleeping
whyrusleeping deleted the feat/go1.7 branch August 26, 2016 02:02
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Aug 26, 2016
@ghost ghost mentioned this pull request Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants