Skip to content

test/sharness: improve t0090 by using printf - #717

Merged
jbenet merged 1 commit into
masterfrom
improve_t0090
Feb 2, 2015
Merged

jbenet merged 1 commit into
masterfrom
improve_t0090

Conversation

@chriscool

Copy link
Copy Markdown
Contributor

License: MIT
Signed-off-by: Christian Couder chriscool@tuxfamily.org

@btc btc added the status/in-progress In progress label Feb 2, 2015
@chriscool

Copy link
Copy Markdown
Contributor Author

There is the following test failure in t0111:


expecting success: 
        cat actual_daemon | grep "API server listening on $ADDR_API" ||
        fsh cat actual_daemon ||
        fsh "cat actual_daemon | grep \"API server listening on $ADDR_API\""

> cat actual_daemon
Initializing daemon...
Gateway server listening on /ip4/0.0.0.0/tcp/5002
Gateway server is writable

> cat actual_daemon | grep "API server listening on /ip4/127.0.0.1/tcp/5001"

not ok 6 - 'ipfs daemon' output includes API address

because it listens on port 5002 instead of 5001, but this is not related to what I changed.

@chriscool

Copy link
Copy Markdown
Contributor Author

The travis build has this:

ok github.com/jbenet/go-ipfs/repo/fsrepo/serialize 0.025s
? github.com/jbenet/go-ipfs/routing [no test files]
--- FAIL: TestProvides (0.37 seconds)
dht_test.go:74: dial attempt failed
01:10:09.763 ERROR dht: did not reach well-formed routing tables by 5s <autogenerated>:25
01:10:10.914 CRITI boguskey: TestBogusPrivateKey.Sign -- this better be a test! <autogenerated>:21
FAIL
FAIL github.com/jbenet/go-ipfs/routing/dht 9.583s
? github.com/jbenet/go-ipfs/routing/dht/pb [no test files]
? github.com/jbenet/go-ipfs/routing/grandcentral [no test files]
? github.com/jbenet/go-ipfs/routing/grandcentral/proxy [no test files]
ok github.com/jbenet/go-ipfs/routing/kbucket 0.234s
ok github.com/jbenet/go-ipfs/routing/keyspace 0.049s

License: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
@jbenet

jbenet commented Feb 2, 2015

Copy link
Copy Markdown
Member

@chriscool yeah there's something really weird going on with some of the test machines. This, coupled with the fact that our config setting was failing silently, makes it hard to figure out what's going on. I've fixed this last part in: #712

I rebased this branch on top of new master so it pulls the changes. (just in case, the previous ref was: ce18cdc )

jbenet added a commit that referenced this pull request Feb 2, 2015
test/sharness: improve t0090 by using printf
@jbenet
jbenet merged commit 6208b1f into master Feb 2, 2015
@jbenet jbenet removed the status/in-progress In progress label Feb 2, 2015
@jbenet
jbenet deleted the improve_t0090 branch February 2, 2015 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants