Skip to content

wantlist command - #719

Merged
jbenet merged 4 commits into
masterfrom
feat/wantlistcmd
Feb 27, 2015
Merged

jbenet merged 4 commits into
masterfrom
feat/wantlistcmd

Conversation

@whyrusleeping

Copy link
Copy Markdown
Member

I wanted to be able to check my wantlist when having trouble resolving things to get a better idea of what was going on. So I made this. not sure what tests to write for it, so if you have any ideas, let me know.

@whyrusleeping whyrusleeping added the status/in-progress In progress label Feb 2, 2015
@jbenet

jbenet commented Feb 2, 2015

Copy link
Copy Markdown
Member

This is a bitswap specific thing. lets put it under

ipfs bitswap wantlist

Comment thread core/commands/bitswap.go Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should still cast the exchange to bitswap, as this is a command called bitswap :) -- it probably shouldnt work with non-bitswap exchanges)

@whyrusleeping

Copy link
Copy Markdown
Member Author

@jbenet is this RFM?

@jbenet

jbenet commented Feb 25, 2015

Copy link
Copy Markdown
Member

@whyrusleeping can you rebase and push again? looks like travis is still complaining about init docs hash (that got fixed, right?)

and, looks like there's a race?

This LGTM, except tests dont seem to be passing

@whyrusleeping

Copy link
Copy Markdown
Member Author

The race doesnt appear to be related to the changes in this PR, I filed a bug for it.

@jbenet

jbenet commented Feb 25, 2015

Copy link
Copy Markdown
Member

@whyrusleeping what about https://build.protocol-dev.com/job/epic/1257/console ? it ran on cassie-- is that a timeout or oom?

@whyrusleeping

Copy link
Copy Markdown
Member Author

That appears to be a timeout, looks like the "bitswap no routing" tests can hang...

@jbenet

jbenet commented Feb 25, 2015

Copy link
Copy Markdown
Member

This is new though. They weren't hanging before. Could it be the bitswap changes last week?

Understand we want to hurry on this PR and ipns but if we let bugs in it will be really hard to squash them later.

—
Sent from Mailbox

On Tue, Feb 24, 2015 at 7:50 PM, Jeromy Johnson notifications@github.com
wrote:

That appears to be a timeout, looks like the "bitswap no routing" tests can hang...

Reply to this email directly or view it on GitHub:
#719 (comment)

@whyrusleeping

Copy link
Copy Markdown
Member Author

Yeah, ive seen it twice before. And I think it has happened since my bitswap changes. Ill look into it.

@whyrusleeping

Copy link
Copy Markdown
Member Author

This is probably caused by my latest bitswap changes, and I think I maybe understand the issue. Ill delve into it more when i get a little more time.

jbenet added a commit that referenced this pull request Feb 27, 2015
@jbenet
jbenet merged commit 2a9cc10 into master Feb 27, 2015
@jbenet jbenet removed the status/in-progress In progress label Feb 27, 2015
@jbenet
jbenet deleted the feat/wantlistcmd branch February 27, 2015 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants