Skip to content

ensure dagreaders are cleaned up after 'cat' command finishes - #722

Merged
jbenet merged 1 commit into
masterfrom
fix/readerclose
Feb 2, 2015
Merged

jbenet merged 1 commit into
masterfrom
fix/readerclose

Conversation

@whyrusleeping

Copy link
Copy Markdown
Member

I beleive i found a goroutine leak bug, if a cat were to be killed before all the data was read, it wouldnt release the underlying processes. This makes sure to pass the correct context into the DagReader

@whyrusleeping whyrusleeping added the status/in-progress In progress label Feb 2, 2015
@whyrusleeping

Copy link
Copy Markdown
Member Author

There appears to be a test failing... really not sure why.

@jbenet jbenet modified the milestone: α Feb 2, 2015
@jbenet

jbenet commented Feb 2, 2015

Copy link
Copy Markdown
Member

Good catch.

jbenet added a commit that referenced this pull request Feb 2, 2015
ensure dagreaders are cleaned up after 'cat' command finishes
@jbenet
jbenet merged commit 4b13b05 into master Feb 2, 2015
@jbenet jbenet removed the status/in-progress In progress label Feb 2, 2015
@jbenet
jbenet deleted the fix/readerclose branch February 2, 2015 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants