Repository navigation
AddrSplosion III - Revenge of the granular TTL - #728
Merged
Merged
Conversation
This addr manager should seriously help with the addrsplosion problem.
This will mitigate the fd explosion, but slow down dials majorly as any peer with more addresses than the rate limit will have to wait a whole dial timeout (~15s)
so that we dont get stuck dialing bad addrs first always.
it keeps failing early.
this will help us introspect what's going on.
TODOs: - need to consolidate all the versioning stuff into one package - need to do the version check as a handshake, before further communication happens. we used to do this.
Member
There was a problem hiding this comment.
how far off of a TODO is this?
Member
|
LGTM! |
Member
Author
|
jbenet
added a commit
that referenced
this pull request
Feb 3, 2015
AddrSplosion III - Revenge of the granular TTL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a granular TTL AddrManager. This way,
every time we add an address, we specify the intended
duration of the addr.
This PR:
ipfs swarm addrscommand for monitoring known addrs