Skip to content

AddrSplosion III - Revenge of the granular TTL - #728

Merged
jbenet merged 11 commits into
masterfrom
addrsplosion
Feb 3, 2015
Merged

jbenet merged 11 commits into
masterfrom
addrsplosion

Conversation

@jbenet

@jbenet jbenet commented Feb 2, 2015

Copy link
Copy Markdown
Member

This PR adds a granular TTL AddrManager. This way,
every time we add an address, we specify the intended
duration of the addr.

This PR:

  • associates addrs with a TTL
  • rate limits dials (10 per peer)
  • adds an ipfs swarm addrs command for monitoring known addrs
  • bumps the protocol version
  • disconnects from clients whose protocol version mismatches

@jbenet jbenet added the status/in-progress In progress label Feb 2, 2015
jbenet added 11 commits February 2, 2015 21:04
This addr manager should seriously help with the addrsplosion
problem.
This will mitigate the fd explosion, but slow down dials majorly
as any peer with more addresses than the rate limit will have
to wait a whole dial timeout (~15s)
so that we dont get stuck dialing bad addrs first always.
this will help us introspect what's going on.
TODOs:
- need to consolidate all the versioning stuff into one package
- need to do the version check as a handshake, before further
  communication happens. we used to do this.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how far off of a TODO is this?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

post alpha

@whyrusleeping

Copy link
Copy Markdown
Member

LGTM!

@jbenet

jbenet commented Feb 3, 2015

Copy link
Copy Markdown
Member Author

⚠️ protocol version bump

after this merges you wont be able to nodes with prior versions

jbenet added a commit that referenced this pull request Feb 3, 2015
AddrSplosion III - Revenge of the granular TTL
@jbenet
jbenet merged commit 61c97f8 into master Feb 3, 2015
@jbenet jbenet removed the status/in-progress In progress label Feb 3, 2015
@jbenet
jbenet deleted the addrsplosion branch February 3, 2015 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants