Skip to content

ratelimiter: fixing rate limiter use - #755

Merged
jbenet merged 1 commit into
masterfrom
fix-ratelimiter-use
Feb 6, 2015
Merged

jbenet merged 1 commit into
masterfrom
fix-ratelimiter-use

Conversation

@jbenet

@jbenet jbenet commented Feb 6, 2015

Copy link
Copy Markdown
Member

Use of the ratelimiter should be conscious of the ratelimiter's
potential closing. any loops that add work to ratelimiter
should (a) only do so if the rate limiter is not closed,
or (b) prevent limiter while work is added
(i.e. use limiter.Go(addWorkHere))

Use of the ratelimiter should be conscious of the ratelimiter's
potential closing. any loops that add work to ratelimiter
should (a) only do so if the rate limiter is not closed,
or (b) prevent limiter while work is added
(i.e. use limiter.Go(addWorkHere))
@jbenet jbenet added the status/in-progress In progress label Feb 6, 2015
@btc

btc commented Feb 6, 2015

Copy link
Copy Markdown
Contributor

do calls to Go contribute to the limit imposed by LimitedGo?

otherwise LGTM

jbenet added a commit that referenced this pull request Feb 6, 2015
ratelimiter: fixing rate limiter use
@jbenet
jbenet merged commit 03c910f into master Feb 6, 2015
@jbenet
jbenet deleted the fix-ratelimiter-use branch February 6, 2015 19:57
@jbenet jbenet removed the status/in-progress In progress label Feb 6, 2015
@aschmahmann aschmahmann mentioned this pull request Dec 1, 2021
79 of 80 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants