Repository navigation
have repo tilde expand paths - #775
Merged
Merged
Conversation
Member
|
I'm fine with this. i dont know all the places its used and whether that violates any assumptions. but tests pass so i guess that's fine. |
Member
|
changes lgtm |
Member
Author
|
I think that anything user facing should accept as wide an array of inputs as possible |
whyrusleeping
added a commit
that referenced
this pull request
Feb 13, 2015
have repo tilde expand paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I work through examples, I feel like it would be much easier for the fsrepo to tilde expand paths given to it. This makes it much easier for users to write the following code:
instead of: