Skip to content

commands.NewRequest() has unexported type in it's arguments - #890

Merged
jbenet merged 1 commit into
masterfrom
fix/cmdsNewRequest
Mar 9, 2015
Merged

jbenet merged 1 commit into
masterfrom
fix/cmdsNewRequest

Conversation

@cryptix

@cryptix cryptix commented Mar 8, 2015

Copy link
Copy Markdown
Contributor

I wanted to play with the daemons JSON API a little, so I hacked together a tiny example in go that just does the equivalent of ipfs ls <hash> .

I only hit a small problem: commands.NewRequest()'s 2nd argument is an unexported map type. This PR removes this. Alternatively we could export it but i don't see much use in that.

@btc btc added the status/in-progress In progress label Mar 8, 2015
@whyrusleeping

Copy link
Copy Markdown
Member

Im not sure whether or not we should just export it... @jbenet thoughts?

Comment thread commands/request.go

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's export OptMap (it's nice small and adds some type safety)

@jbenet

jbenet commented Mar 8, 2015

Copy link
Copy Markdown
Member

one comment above

@cryptix
cryptix force-pushed the fix/cmdsNewRequest branch from d50ab22 to 86b34a2 Compare March 8, 2015 11:15
@cryptix

cryptix commented Mar 8, 2015

Copy link
Copy Markdown
Contributor Author

exported instead

@whyrusleeping

Copy link
Copy Markdown
Member

LGTM, RFM

jbenet added a commit that referenced this pull request Mar 9, 2015
commands.NewRequest() has unexported type in it's arguments
@jbenet
jbenet merged commit e015337 into master Mar 9, 2015
@jbenet jbenet removed the status/in-progress In progress label Mar 9, 2015
@jbenet
jbenet deleted the fix/cmdsNewRequest branch March 9, 2015 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants