Skip to content

cache public keys and use better method for fetching - #987

Merged
whyrusleeping merged 2 commits into
masterfrom
feat/pubkey-cache
Apr 1, 2015
Merged

whyrusleeping merged 2 commits into
masterfrom
feat/pubkey-cache

Conversation

@whyrusleeping

Copy link
Copy Markdown
Member

created a new interface for optimized public key fetching that the DHT implements, otherwise fall back to a standard routing search.

@whyrusleeping whyrusleeping added topic/dht Topic dht topic/ipns Topic ipns labels Mar 30, 2015
@whyrusleeping whyrusleeping self-assigned this Mar 30, 2015
@whyrusleeping whyrusleeping added the status/in-progress In progress label Mar 30, 2015
Comment thread namesys/routing.go Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a pretty big function-- maybe abstract this piece (grabbing the key from routing) into a

func (r *routingResolver) getPublicKey(...) {}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe even this could go in routing/routing.go as:

func GetPublicKey(r Routing, ...) {}

@jbenet

jbenet commented Mar 30, 2015

Copy link
Copy Markdown
Member

Couple comments above, otherwise lgtm

@whyrusleeping whyrusleeping added codereview and removed status/in-progress In progress labels Mar 31, 2015
@jbenet jbenet mentioned this pull request Mar 31, 2015
21 of 52 tasks
@whyrusleeping
whyrusleeping force-pushed the feat/pubkey-cache branch 2 times, most recently from 69c7122 to bb1b0d5 Compare April 1, 2015 01:16
whyrusleeping added a commit that referenced this pull request Apr 1, 2015
cache public keys and use better method for fetching
@whyrusleeping
whyrusleeping merged commit be598ad into master Apr 1, 2015
@jbenet
jbenet deleted the feat/pubkey-cache branch April 1, 2015 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic/dht Topic dht topic/ipns Topic ipns

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants