Skip to content

fix: Fixes #14146 Twitter Navigation URL - #14154

Merged
SimenB merged 2 commits into
jestjs:mainfrom
bharathkalyans:bharathkalyans/issue-14146
May 23, 2023
Merged

SimenB merged 2 commits into
jestjs:mainfrom
bharathkalyans:bharathkalyans/issue-14146

Conversation

@bharathkalyans

Copy link
Copy Markdown
Contributor

Summary

  • The codebase had the wrong Twitter URL path.
  • Changed it to the correct Twitter URL path and also renamed all fbjest instances with jestjs_.

Test plan

@linux-foundation-easycla

linux-foundation-easycla Bot commented May 23, 2023 •

Copy link
Copy Markdown

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: bharathkalyans / name: Bharath Kalyan S (a41b807)

@netlify

netlify Bot commented May 23, 2023 •

Copy link
Copy Markdown

✅ Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 311e735
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/646cd1e6dcb4db00084118de
😎 Deploy Preview https://deploy-preview-14154--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@SimenB SimenB left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! can you sign the CLA?

@bharathkalyans

Copy link
Copy Markdown
Contributor Author

@SimenB Completed signing the CLA.
Signed as an Individual Contributor 😀

@SimenB

SimenB commented May 23, 2023

Copy link
Copy Markdown
Member

Could you run prettier over the changed files?

@bharathkalyans

Copy link
Copy Markdown
Contributor Author
  • Sorry for the inconvenience @SimenB, should have run prettier over the changed files before pinging you.
  • The latest commit passed all the required checks.

@SimenB
SimenB merged commit 8403030 into jestjs:main May 23, 2023
@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 23, 2023
@bharathkalyans
bharathkalyans deleted the bharathkalyans/issue-14146 branch June 23, 2023 07:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants