You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Export ArrayByteBufferPool statistics via JMXΒ #12706
Where I can find ArrayByteBufferPool allocation/bucket statistics (aggregated, not per-retainable buffer)? Seem like ArrayByteBufferPool.setStatisticsEnabled a noop from JMX perspective
@wendigo the statistics are in the dump() of ArrayByteBufferPool.
Can you specify what would you be doing with aggregate statistics?
I'm not sure what exact parameter you are interested in, and aggregates across all buckets seem not that interesting -- you won't be able to tell much from an aggregate number.
Activity
joakime commentedon Jan 13, 2025
The statistics are only per RetainedBucket, there's no aggregate statistics.
wendigo commentedon Jan 13, 2025
@joakime does it make sense to add aggregate to the Pool itself?
sbordet commentedon Jan 13, 2025
@wendigo the statistics are in the
dump()ofArrayByteBufferPool.Can you specify what would you be doing with aggregate statistics?
I'm not sure what exact parameter you are interested in, and aggregates across all buckets seem not that interesting -- you won't be able to tell much from an aggregate number.
wendigo commentedon Jan 13, 2025
@sbordet the distribution of allocation sizes mostly, size of currently allocated memory
wendigo commentedon Jan 13, 2025
Basically we want to make sure that the pool is configured accordingly to our actual usage
sbordet commentedon Jan 13, 2025
@wendigo then you don't want aggregates, but per-bucket statistics, which is already available in the dump.
Is that sufficient?
wendigo commentedon Jan 13, 2025
@sbordet i'd like that information to be exported as mbean so I can track it in datadog
sbordet commentedon Jan 13, 2025
@wendigo ok, we will need to do some work with JMX open types, since the data you want is tabular.
[-]ArrayByteBufferPool.isStatisticsEnabled[/-][+]Export ArrayByteBufferPool statistics via JMX[/+]Fixes #12706 - Export ArrayByteBufferPool statistics via JMX.
sbordet commentedon Jan 14, 2025
@wendigo could you check #12709 and see if that's enough for you?
wendigo commentedon Jan 14, 2025
@sbordet yes, I can that test, just give me an hour or two
Fixes jetty#12706 - Export ArrayByteBufferPool statistics via JMX. (jβ¦
Fixes #12706 - Export ArrayByteBufferPool statistics via JMX. (#12709)