Skip to content

Export ArrayByteBufferPool statistics via JMXΒ #12706

Closed

Description

@wendigo

Jetty Version

12.x

Jetty Environment

ee10

Java Version

Question

Where I can find ArrayByteBufferPool allocation/bucket statistics (aggregated, not per-retainable buffer)? Seem like ArrayByteBufferPool.setStatisticsEnabled a noop from JMX perspective

Activity

  1. joakime commented on Jan 13, 2025

    @joakime
    Contributor

    The statistics are only per RetainedBucket, there's no aggregate statistics.

  2. wendigo commented on Jan 13, 2025

    @wendigo
    ContributorAuthor

    @joakime does it make sense to add aggregate to the Pool itself?

  3. sbordet commented on Jan 13, 2025

    @sbordet
    Contributor

    @wendigo the statistics are in the dump() of ArrayByteBufferPool.

    Can you specify what would you be doing with aggregate statistics?
    I'm not sure what exact parameter you are interested in, and aggregates across all buckets seem not that interesting -- you won't be able to tell much from an aggregate number.

  4. wendigo commented on Jan 13, 2025

    @wendigo
    ContributorAuthor

    @sbordet the distribution of allocation sizes mostly, size of currently allocated memory

  5. wendigo commented on Jan 13, 2025

    @wendigo
    ContributorAuthor

    Basically we want to make sure that the pool is configured accordingly to our actual usage

  6. sbordet commented on Jan 13, 2025

    @sbordet
    Contributor

    @wendigo then you don't want aggregates, but per-bucket statistics, which is already available in the dump.
    Is that sufficient?

  7. wendigo commented on Jan 13, 2025

    @wendigo
    ContributorAuthor

    @sbordet i'd like that information to be exported as mbean so I can track it in datadog

  8. sbordet commented on Jan 13, 2025

    @sbordet
    Contributor

    @wendigo ok, we will need to do some work with JMX open types, since the data you want is tabular.

  9. changed the title [-]ArrayByteBufferPool.isStatisticsEnabled[/-] [+]Export ArrayByteBufferPool statistics via JMX[/+] on Jan 13, 2025
  10. added
    SponsoredThis issue affects a user with a commercial support agreement
    and removed on Jan 13, 2025
  11. added a commit that references this issue on Jan 14, 2025
    a272370
  12. moved this to πŸ— In progress in Jetty 12.0.17 - FROZENon Jan 14, 2025
  13. sbordet commented on Jan 14, 2025

    @sbordet
    Contributor

    @wendigo could you check #12709 and see if that's enough for you?

  14. wendigo commented on Jan 14, 2025

    @wendigo
    ContributorAuthor

    @sbordet yes, I can that test, just give me an hour or two

  15. self-assigned this
    on Feb 5, 2025
  16. moved this from πŸ— In progress to βœ… Done in Jetty 12.0.17 - FROZENon Feb 6, 2025
  17. added a commit that references this issue on Feb 6, 2025
    a57b7db
  18. added a commit that references this issue on Feb 9, 2025
    874da77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

EnhancementSponsoredThis issue affects a user with a commercial support agreement

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions