You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Support Digest authentication with SHA-256Β #13127
I was invited to submit a PR for this based on my code at https://github.com/zzzi2p/jetty-multiauth . Unfortunately I won't be able due to lack of time and ability to test because my project is on 9.3/9.4. So I offer my code for some motivated person to adapt into a PR.
My class is an all-in-one authenticator that does SHA256, MD5, and Basic, if enabled. A couple things to consider:
@arsenalzp yes we need to implement this.
On the client, it is already implemented, but on the server it's hardcoded and we would like to have it configurable.
@arsenalzp yes we need to implement this. On the client, it is already implemented, but on the server it's hardcoded and we would like to have it configurable.
A similar fix should be applied to org.eclipse.jetty.ee9.security.authentication.DigestAuthenticator.
A test case using the client should be added in the ee9, ee10, ee11 oej.eeN.test.DigestPostTest.
Hello,
I've just seen there is hardcoded MD5 algorithm in digest authentication DigestAuthenticator class. It is in 12.1.x branch, so no changes since 12.0.x.
Activity
zzzi2p commentedon May 13, 2025
I was invited to submit a PR for this based on my code at https://github.com/zzzi2p/jetty-multiauth . Unfortunately I won't be able due to lack of time and ability to test because my project is on 9.3/9.4. So I offer my code for some motivated person to adapt into a PR.
My class is an all-in-one authenticator that does SHA256, MD5, and Basic, if enabled. A couple things to consider:
joakime commentedon May 13, 2025
@zzzi2p you know that Jetty 9.3/9.4 is EOL right?
zzzi2p commentedon May 13, 2025
of course; we're on it for Java 8 support.
arsenalzp commentedon May 25, 2025
Hello,
Do you need support on this?
sbordet commentedon May 26, 2025
@arsenalzp yes we need to implement this.
On the client, it is already implemented, but on the server it's hardcoded and we would like to have it configurable.
Have a look at
org.eclipse.jetty.security.authentication.DigestAuthenticator, in particular:https://github.com/jetty/jetty.project/blob/jetty-12.0.21/jetty-core/jetty-security/src/main/java/org/eclipse/jetty/security/authentication/DigestAuthenticator.java#L180
A similar fix should be applied to
org.eclipse.jetty.ee9.security.authentication.DigestAuthenticator.A test case using the client should be added in the ee9, ee10, ee11
oej.eeN.test.DigestPostTest.arsenalzp commentedon May 27, 2025
/assign
arsenalzp commentedon May 31, 2025
Hello,
I've just seen there is hardcoded MD5 algorithm in digest authentication
DigestAuthenticatorclass. It is in 12.1.x branch, so no changes since 12.0.x.sbordet commentedon Jun 3, 2025
@arsenalzp yes, please make the changes in the
jetty-12.1.xbranch.arsenalzp commentedon Jun 4, 2025
Sure!
Isse #13127 - Support Digest authentication with SHA-256.
sbordet commentedon Jul 2, 2025
Implemented by #13236.