You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description
Currently, jetty-ee9-proxy.xml is broken as it references the non-existing class org.eclipse.jetty.ee9.proxy.ConnectHandler that does not exist because it has been moved to core as org.eclipse.jetty.server.handler.ConnectHandler.
But when trying to fix the class name, we get an ambiguity because class org.eclipse.jetty.server.Handler has 2 methods named setHandler(), one that takes a Handler parameter, and one that takes a Supplier<Handler>, so the <Set> element fails.
Trying to fix that by using <Call> instead of <Set> results in another error because org.eclipse.jetty.ee9.servlet.ServletHandler is not a org.eclipse.jetty.server.Handler but rather a org.eclipse.jetty.ee9.nested.Handler.
XmlConfiguration should be able to work out which method to use by the arg type? Something else is wrong here?
It would be difficult, as you would have to navigate the hierarchy of classes and interfaces.
For some (historical?) reason, we run through all the methods until one succeeds for <Call>, but we bail out immediately in case of ambiguity for <Set>.
I don't think what it is trying to do can be done. You can't put a core handler between nested handlers.
It either needs to wrap the entire core context or be inserted between the core context handler and the adaptor handler that converts to a nested handlers chain
@sbordet The nested context handler has a core context handler that is provided by the supplier api. It's handler is the adapter. So you could insert between those two.
This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.
This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.
Activity
sbordet commentedon May 24, 2023
@gregw two questions:
org.eclipse.jetty.server.Handler.setHandler(Supplier<Handler>)to avoid the ambiguity?Handlers with ee9nested.Handlers?For this particular case, we can restore an ee9
ConnectHandler, but we duplicate all the code.gregw commentedon May 25, 2023
@sbordet The supplier technique is used to add nested handlers to core handlers.
XmlConfiguration should be able to work out which method to use by the arg type? Something else is wrong here?
sbordet commentedon May 25, 2023
It would be difficult, as you would have to navigate the hierarchy of classes and interfaces.
For some (historical?) reason, we run through all the methods until one succeeds for
<Call>, but we bail out immediately in case of ambiguity for<Set>.gregw commentedon May 25, 2023
@sbordet
I don't think what it is trying to do can be done. You can't put a core handler between nested handlers.
It either needs to wrap the entire core context or be inserted between the core context handler and the adaptor handler that converts to a nested handlers chain
gregw commentedon May 25, 2023
@sbordet The nested context handler has a core context handler that is provided by the supplier api. It's handler is the adapter. So you could insert between those two.
github-actions commentedon May 25, 2024
This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.
github-actions commentedon Jun 27, 2025
This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.
Fixes #9794 - Jetty 12 - jetty-ee9-proxy.xml broken.
Fixes #9794 - Jetty 12 - jetty-ee9-proxy.xml broken.