Repository navigation
Common Annotation Parser - #13122
Common Annotation Parser#13122
Conversation
joakime
left a comment
There was a problem hiding this comment.
Use the src/main/config system please.
And I think we shouldn't reintroduce an old deprecated module name.
|
|
||
| [depend] | ||
| ee10-plus | ||
| annotations |
There was a problem hiding this comment.
This reintroduces a module name that we deprecated.
Those that use Jetty 10/11 will find that using annotations works, but not in the way they think.
Perhaps this should be core-annotations? or common-annotations?
There was a problem hiding this comment.
I don't think that is a big concern. Most of our core modules do not have a core- prefix, so I don't think it is necessary.
There was a problem hiding this comment.
Yes, but that's not what I'm talking about. :-)
The annotations.mod existed in Jetty 9/10/11 to provide webapp level annotations support.
We deprecated that name in Jetty 12 (removed it actually, to intentionally cause an error on start.jar. like we do for all of the module name that are now env specific), so we don't want to re-introduce the old annotations name again.
There was a problem hiding this comment.
We want the error from old use of --module=annotations (in start.d/*.ini) to inform users that they need to pick a specific env version now.
There was a problem hiding this comment.
I understand what you are saying, but I don't think it is a big enough concern to pervert the naming of a module.
The module was gone from 12.0, so it is OK to re-add in 12.1.x
There was a problem hiding this comment.
I don't see this as perverting the name of a module.
The current annotations mod in this PR is actually an internal module, one that itself doesn't do anything useful, you have to use the ee10-annotations to have something be useful.
This module should probably be core/annotations or something similar that doesn't expose it to be directly selectable / enabled / show up in --list-modules, etc.
janbartel
left a comment
There was a problem hiding this comment.
I think the dependency of jetty-ee on the asm artifacts is superfluous?
…1.x/commonAnnotations
Move Annotation parser to jetty-core