Skip to content

Common Annotation Parser - #13122

Merged
gregw merged 12 commits into
jetty-12.1.xfrom
fix/jetty-12.1.x/commonAnnotations
May 13, 2025
Merged

gregw merged 12 commits into
jetty-12.1.xfrom
fix/jetty-12.1.x/commonAnnotations

Conversation

@gregw

@gregw gregw commented May 11, 2025

Copy link
Copy Markdown
Contributor

Move Annotation parser to jetty-core

@gregw
gregw marked this pull request as ready for review May 12, 2025 00:53
@gregw
gregw requested a review from janbartel May 12, 2025 00:53
@gregw
gregw requested a review from joakime May 12, 2025 05:04

@joakime joakime left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the src/main/config system please.
And I think we shouldn't reintroduce an old deprecated module name.


[depend]
ee10-plus
annotations

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reintroduces a module name that we deprecated.
Those that use Jetty 10/11 will find that using annotations works, but not in the way they think.
Perhaps this should be core-annotations? or common-annotations?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that is a big concern. Most of our core modules do not have a core- prefix, so I don't think it is necessary.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but that's not what I'm talking about. :-)

The annotations.mod existed in Jetty 9/10/11 to provide webapp level annotations support.

Example -> https://github.com/jetty/jetty.project/blob/jetty-11.0.25/jetty-annotations/src/main/config/modules/annotations.mod

We deprecated that name in Jetty 12 (removed it actually, to intentionally cause an error on start.jar. like we do for all of the module name that are now env specific), so we don't want to re-introduce the old annotations name again.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want the error from old use of --module=annotations (in start.d/*.ini) to inform users that they need to pick a specific env version now.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand what you are saying, but I don't think it is a big enough concern to pervert the naming of a module.
The module was gone from 12.0, so it is OK to re-add in 12.1.x

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this as perverting the name of a module.
The current annotations mod in this PR is actually an internal module, one that itself doesn't do anything useful, you have to use the ee10-annotations to have something be useful.
This module should probably be core/annotations or something similar that doesn't expose it to be directly selectable / enabled / show up in --list-modules, etc.

@gregw
gregw requested a review from joakime May 12, 2025 22:45

@janbartel janbartel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the dependency of jetty-ee on the asm artifacts is superfluous?

Comment thread jetty-core/jetty-ee/pom.xml Resolved
@gregw
gregw requested a review from janbartel May 13, 2025 00:14
@gregw
gregw merged commit 499e4f5 into jetty-12.1.x May 13, 2025
@gregw
gregw deleted the fix/jetty-12.1.x/commonAnnotations branch May 13, 2025 22:07
@olamy olamy mentioned this pull request Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants