Skip to content

Strengthened connection failure handling. - #15668

Merged
sbordet merged 3 commits into
jetty-12.1.xfrom
fix/jetty-12.1.x/improve-connect-failure-handling
Aug 28, 2026
Merged

sbordet merged 3 commits into
jetty-12.1.xfrom
fix/jetty-12.1.x/improve-connect-failure-handling

Conversation

@sbordet

@sbordet sbordet commented Aug 26, 2026

Copy link
Copy Markdown
Contributor
  • Connect operations may go through either SelectorManager.connect() or SelectorManager.accept(); added failure handling for the latter similar to the former.
  • Updated ManagedSelector.Accept and ManagedSelector.CreateEndPoint to implement Closeable, so that they are processed in case of failures.
  • Updated ManagedSelector.CloseConnections to close key attachments that are Closeable (not only EndPoint).
  • Updated SelectorManager to handle the case where the ManagedSelector is null because SelectorManager is stopping.
  • Fixed UnixDomainServerConnector.setAccepting(): the non-blocking logic must be executed when the number of acceptors is zero.

* Connect operations may go through either SelectorManager.connect() or SelectorManager.accept(); added failure handling for the latter similar to the former.
* Updated ManagedSelector.Accept and ManagedSelector.CreateEndPoint to implement Closeable, so that they are processed in case of failures.
* Updated ManagedSelector.CloseConnections to close key attachments that are Closeable (not only EndPoint).
* Updated SelectorManager to handle the case where the ManagedSelector is null because SelectorManager is stopping.
* Fixed UnixDomainServerConnector.setAccepting(): the non-blocking logic must be executed when the number of acceptors is zero.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet
sbordet requested a review from lorban August 26, 2026 08:26
@sbordet sbordet self-assigned this Aug 26, 2026
@sbordet sbordet moved this to 👀 In review in FROZEN Jetty 12.1.13 Aug 26, 2026
@sbordet sbordet added the Sponsored This issue affects a user with a commercial support agreement label Aug 26, 2026
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
lorban
lorban previously approved these changes Aug 27, 2026

@lorban lorban left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple naming nits and one remark to ponder about, otherwise LGTM.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet
sbordet merged commit 98da0df into jetty-12.1.x Aug 28, 2026
6 of 10 checks passed
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in FROZEN Jetty 12.1.13 Aug 28, 2026
@sbordet
sbordet deleted the fix/jetty-12.1.x/improve-connect-failure-handling branch August 28, 2026 08:10
sbordet added a commit that referenced this pull request Aug 28, 2026
* Connect operations may go through either SelectorManager.connect() or SelectorManager.accept(); added failure handling for the latter similar to the former.
* Updated ManagedSelector.Accept and ManagedSelector.CreateEndPoint to implement Closeable, so that they are processed in case of failures.
* Updated ManagedSelector.CloseConnections to close key attachments that are Closeable (not only EndPoint).
* Updated SelectorManager to handle the case where the ManagedSelector is null because SelectorManager is stopping.
* Fixed UnixDomainServerConnector.setAccepting(): the non-blocking logic must be executed when the number of acceptors is zero.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
(cherry picked from commit 98da0df)
dongjoon-hyun added a commit to apache/spark that referenced this pull request Sep 19, 2026
### What changes were proposed in this pull request?

This PR upgrades Jetty to `12.1.13`.

### Why are the changes needed?

To bring in the latest upstream bug fixes and improvements from the Jetty 12.1.x patch release line.

- https://github.com/jetty/jetty.project/releases/tag/jetty-12.1.13 (2026-09-07)
  - jetty/jetty.project#15668
  - jetty/jetty.project#15612
  - jetty/jetty.project#15548
- https://github.com/jetty/jetty.project/releases/tag/jetty-12.1.12 (2026-08-04)
  - jetty/jetty.project#15453
  - jetty/jetty.project#13970
  - jetty/jetty.project#577

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

Generated-by: Claude Opus 5

Closes #58916 from dongjoon-hyun/SPARK-59647.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Sponsored This issue affects a user with a commercial support agreement

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants