Repository navigation
Strengthened connection failure handling. - #15668
Merged
sbordet merged 3 commits intoAug 28, 2026
Merged
Conversation
sbordet
commented
Aug 26, 2026
Contributor
- Connect operations may go through either SelectorManager.connect() or SelectorManager.accept(); added failure handling for the latter similar to the former.
- Updated ManagedSelector.Accept and ManagedSelector.CreateEndPoint to implement Closeable, so that they are processed in case of failures.
- Updated ManagedSelector.CloseConnections to close key attachments that are Closeable (not only EndPoint).
- Updated SelectorManager to handle the case where the ManagedSelector is null because SelectorManager is stopping.
- Fixed UnixDomainServerConnector.setAccepting(): the non-blocking logic must be executed when the number of acceptors is zero.
* Connect operations may go through either SelectorManager.connect() or SelectorManager.accept(); added failure handling for the latter similar to the former. * Updated ManagedSelector.Accept and ManagedSelector.CreateEndPoint to implement Closeable, so that they are processed in case of failures. * Updated ManagedSelector.CloseConnections to close key attachments that are Closeable (not only EndPoint). * Updated SelectorManager to handle the case where the ManagedSelector is null because SelectorManager is stopping. * Fixed UnixDomainServerConnector.setAccepting(): the non-blocking logic must be executed when the number of acceptors is zero. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
lorban
previously approved these changes
Aug 27, 2026
lorban
left a comment
Contributor
There was a problem hiding this comment.
A couple naming nits and one remark to ponder about, otherwise LGTM.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet
added a commit
that referenced
this pull request
Aug 28, 2026
* Connect operations may go through either SelectorManager.connect() or SelectorManager.accept(); added failure handling for the latter similar to the former. * Updated ManagedSelector.Accept and ManagedSelector.CreateEndPoint to implement Closeable, so that they are processed in case of failures. * Updated ManagedSelector.CloseConnections to close key attachments that are Closeable (not only EndPoint). * Updated SelectorManager to handle the case where the ManagedSelector is null because SelectorManager is stopping. * Fixed UnixDomainServerConnector.setAccepting(): the non-blocking logic must be executed when the number of acceptors is zero. Signed-off-by: Simone Bordet <simone.bordet@gmail.com> (cherry picked from commit 98da0df)
dongjoon-hyun
added a commit
to apache/spark
that referenced
this pull request
Sep 19, 2026
### What changes were proposed in this pull request? This PR upgrades Jetty to `12.1.13`. ### Why are the changes needed? To bring in the latest upstream bug fixes and improvements from the Jetty 12.1.x patch release line. - https://github.com/jetty/jetty.project/releases/tag/jetty-12.1.13 (2026-09-07) - jetty/jetty.project#15668 - jetty/jetty.project#15612 - jetty/jetty.project#15548 - https://github.com/jetty/jetty.project/releases/tag/jetty-12.1.12 (2026-08-04) - jetty/jetty.project#15453 - jetty/jetty.project#13970 - jetty/jetty.project#577 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 5 Closes #58916 from dongjoon-hyun/SPARK-59647. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
1 of 11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.