Repository navigation
12.0.x: Issue #15941 - release Deflater after each message without context takeover - #15943
Merged
lachlan-roberts merged 1 commit intoOct 12, 2026
Conversation
…xt takeover With server_no_context_takeover, the Deflater was released to the pool after the final frame of a message, but clearing its input afterwards acquired a new one from the pool. Every session kept holding a Deflater (and its native zlib memory) between messages. Only clear the input when the session still holds a Deflater. A released Deflater is already reset by the pool. Backport of jetty#15942 to jetty-12.0.x. Signed-off-by: Stefan Roex <stefan@brightmotive.com>
stefanroex
force-pushed
the
fix/15941/jetty-12.0.x/permessage-deflate-release
branch
from
October 9, 2026 07:08
2eaecca to
89d487f
Compare
lachlan-roberts
self-requested a review
October 12, 2026 02:19
lachlan-roberts
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #15942 to 12.0.x for issue #15941.
The code around the fix differs from 12.1.x, so this is a manual port rather than a cherry-pick. The test is the version requested in the 12.1.x review:
AbstractExtensionTeststarts and stops the sharedWebSocketComponentsaround each test, and the new test asserts against itsDeflaterPool.