Improper Html closing tag results in addition of text nodes

Jsoup is not able determine improperly closed html tags.
For example,
<a> hello </a< would result in <a> hello </a><
<div> hello </div<> would result in <div> hello </div><>

Browsers will properly close the tags and does not add a < or > text nodes like Jsoup

See #797 - at that point we moved out of spec. But the spec used to add the < character as an attribute name, not to the tag name. https://html.spec.whatwg.org/multipage/parsing.html#tag-name-state

Will review moving closer to spec and impact.

OK, I've aligned it to the current spec. That allows tag names like a<b (and you can see that in Chrome with HTML like <div> hello </div<> <a>One<a<b>Hello</b>). That's pretty gross IMO, but better for us to be consistent.

Allow `<` in tag name state

This change just pointed me to some invalid HTML that I was generating, so thanks! 🙂

I was generating (more or less) the following:

<table><th</></th></table>

1.18.1 turned that into

<html>
 <head></head>
 <body>
  <table>
   <tbody>
    <tr>
     <th></th>
    </tr>
   </tbody>
  </table>
 </body>
</html>

Now, with 1.18.2, it get

<html>
 <head></head>
 <body>
  <th< />
  <table></table>
 </body>
</html>

I assume that it's related to this change. I just wanted to make sure that the new behavior is expected.

@jochenberger

Thanks @jochenberger -- yes that is what we would expect now. The previous #797 behavior was probably a better experience for this case, but ultimately lead to too much difference betwen browsers/spec and jsoup.

The th< tag is getting promoted ahead of the table tag in your instance due to the table parsing rules that move non-table elements out of the table.

chore(deps): update all non-major dependencies (mulk/mulkcms2!58)

Navigation Menu

Repository navigation

Improper Html closing tag results in addition of text nodes #2230

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Improper Html closing tag results in addition of text nodes #2230

Description

Activity

jhy commented on Nov 23, 2024

jhy commented on Nov 23, 2024

jochenberger commented on Nov 29, 2024

jhy commented on Dec 3, 2024

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions