Repository navigation
Exclude examples from artifacts - #700
Merged
Merged
Conversation
Added exclude rules in the pom.xml to prevent the classes from the org.jsoup.examples package to be included in the *.jar and *-sources.jar artifacts.
Owner
|
Thanks! Merged. |
This was referenced Apr 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the examples from the main source tree appear in the release artifacts. Assuming that this is not intended, I have setup a patch that prevents the classes from the org.jsoup.examples package from being included in the *.jar and *-sources.jar artifacts.
I think an alternative approach would be to move the examples to a separate source tree (or different project). What do you think?