Skip to content

[6.2] Small readability fixes - #45237

Merged
MacJoom merged 13 commits into
joomla:6.2-devfrom
blueboar2:6.0-dev
Jun 19, 2026
Merged

MacJoom merged 13 commits into
joomla:6.2-devfrom
blueboar2:6.0-dev

Conversation

@blueboar2

@blueboar2 blueboar2 commented Mar 28, 2025 •

Copy link
Copy Markdown
Contributor

Pull Request.

Summary of Changes

Just small readability fixes. Mainly changing "if (something) return true else false" to shorter version "return something".

@exlemor

exlemor commented Mar 29, 2025

Copy link
Copy Markdown

Hi @blueboar2, please 🙏 include Testing Instructions so that we can test your PRs. Thank you so much. :)

@Bodge-IT Bodge-IT added the RMDQ ReleaseManagerDecisionQueue label May 19, 2025
@QuyTon

QuyTon commented May 20, 2025

Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 62b5dde

Code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45237.

@bembelimen

Copy link
Copy Markdown
Contributor

Thanks for your first contribution, we have put in some suggestion, probably you could review.

thank you very much again!

@bembelimen bembelimen added the bug label Aug 20, 2025
@HLeithner HLeithner changed the title Small readability fixes [6.0] Small readability fixes Aug 31, 2025
blueboar2 and others added 4 commits September 19, 2025 22:54
…40.php

Co-authored-by: Harald Leithner <leithner@itronic.at>
Co-authored-by: Harald Leithner <leithner@itronic.at>
Co-authored-by: Harald Leithner <leithner@itronic.at>
…l.php

Co-authored-by: Benjamin Trenkle <bembelimen@users.noreply.github.com>
@blueboar2

Copy link
Copy Markdown
Contributor Author

Thanks for your first contribution, we have put in some suggestion, probably you could review.

thank you very much again!

Thanks, I have reviewed comments and accept most of them. Could you review it now?

…l.php

Co-authored-by: Harald Leithner <leithner@itronic.at>
@Bodge-IT
Bodge-IT changed the base branch from 6.0-dev to 6.1-dev December 17, 2025 08:25
@Bodge-IT Bodge-IT changed the title [6.0] Small readability fixes [6.1] Small readability fixes Dec 17, 2025
@Bodge-IT

Copy link
Copy Markdown
Contributor

Thanks for this work @BlueBoar, unfortunately can't squeeze this into 6.0 now, don't want to see it go stale...moved to 6.1

@blueboar2

Copy link
Copy Markdown
Contributor Author

Thanks for this work @BlueBoar, unfortunately can't squeeze this into 6.0 now, don't want to see it go stale...moved to 6.1

Thank you!

@joomdonation

Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on be5edaa

Code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45237.

@QuyTon

QuyTon commented May 15, 2026

Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on be5edaa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45237.

@QuyTon

QuyTon commented May 15, 2026

Copy link
Copy Markdown
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45237.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 15, 2026
@HLeithner
HLeithner changed the base branch from 6.1-dev to 6.2-dev June 19, 2026 07:28
@HLeithner HLeithner changed the title [6.1] Small readability fixes [6.2] Small readability fixes Jun 19, 2026
@HLeithner

Copy link
Copy Markdown
Member

Since this is not a bugfix I rebased this to 6.2 @MacJoom please merge.

@laoneo laoneo added this to the Joomla! 6.2.0 milestone Jun 19, 2026
@laoneo laoneo added Feature and removed bug labels Jun 19, 2026
@MacJoom

MacJoom commented Jun 19, 2026

Copy link
Copy Markdown
Member

@bembelimen - whats the requested change - i can't see it - thank you

@brianteeman

Copy link
Copy Markdown
Contributor

@MacJoom #45237 (review)

@joomdonation

Copy link
Copy Markdown
Contributor

@MacJoom There were three requested changes: two were implemented, one is invalid. So the PR is fine as how it is now. You can merge it.

@MacJoom
MacJoom dismissed bembelimen’s stale review June 19, 2026 09:52

No change requested

@MacJoom
MacJoom merged commit 64096f4 into joomla:6.2-dev Jun 19, 2026
57 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 19, 2026
@MacJoom

MacJoom commented Jun 19, 2026

Copy link
Copy Markdown
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.