Repository navigation
[6.2] Small readability fixes - #45237
Conversation
|
Hi @blueboar2, please 🙏 include Testing Instructions so that we can test your PRs. Thank you so much. :) |
|
I have tested this item ✅ successfully on 62b5dde This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45237. |
|
Thanks for your first contribution, we have put in some suggestion, probably you could review. thank you very much again! |
…40.php Co-authored-by: Harald Leithner <leithner@itronic.at>
Co-authored-by: Harald Leithner <leithner@itronic.at>
Co-authored-by: Harald Leithner <leithner@itronic.at>
…l.php Co-authored-by: Benjamin Trenkle <bembelimen@users.noreply.github.com>
Thanks, I have reviewed comments and accept most of them. Could you review it now? |
…l.php Co-authored-by: Harald Leithner <leithner@itronic.at>
|
Thanks for this work @BlueBoar, unfortunately can't squeeze this into 6.0 now, don't want to see it go stale...moved to 6.1 |
Thank you! |
|
I have tested this item ✅ successfully on be5edaa This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45237. |
|
I have tested this item ✅ successfully on be5edaa This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45237. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45237. |
|
Since this is not a bugfix I rebased this to 6.2 @MacJoom please merge. |
|
@bembelimen - whats the requested change - i can't see it - thank you |
|
@MacJoom There were three requested changes: two were implemented, one is invalid. So the PR is fine as how it is now. You can merge it. |
|
Thank you! |
Pull Request.
Summary of Changes
Just small readability fixes. Mainly changing "if (something) return true else false" to shorter version "return something".