Skip to content

[6.2] Revert #47794 and align paths for codemirror builder - #47823

Merged
MacJoom merged 3 commits into
joomla:6.2-devfrom
LadySolveig:6.2/fix/build/build-license-codemirror
May 24, 2026
Merged

MacJoom merged 3 commits into
joomla:6.2-devfrom
LadySolveig:6.2/fix/build/build-license-codemirror

Conversation

@LadySolveig

@LadySolveig LadySolveig commented May 24, 2026 •

Copy link
Copy Markdown
Contributor

Pull Request resolves ##47794 (comment) .

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

This pull request makes a small update to the CodemirrorModuleBuilder class to fix the vendor path for CodeMirror dependencies. The new path points to the correct directory where the CodeMirror JavaScript files are located.

Testing Instructions

run npm ci

Actual result BEFORE applying this Pull Request

Wrong targetPath: media/plg_editors_codemirror/js/LICENSE

Expected result AFTER applying this Pull Request

Right targetPath: media/vendor/codemirror/LICENSE

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Thanks for bringing this up and for your support @heelc29

…and compile in plg_system_codemirror

Co-authored-by: Christian Heel <66922325+heelc29@users.noreply.github.com>
@LadySolveig
LadySolveig marked this pull request as ready for review May 24, 2026 12:17
@richard67

Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on 9de1cb3

I have successfully reproduced the issue and tested that this PR fixes it without causing any other differences in the media folder.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47823.

@brianteeman

Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 9de1cb3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47823.

@MacJoom MacJoom added this to the Joomla! 6.2.0 milestone May 24, 2026
@MacJoom
MacJoom merged commit 9165221 into joomla:6.2-dev May 24, 2026
53 checks passed
@MacJoom

MacJoom commented May 24, 2026

Copy link
Copy Markdown
Member

Thank you all - authors, reviewers and testers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants