Repository navigation
[6.2] Revert #47794 and align paths for codemirror builder - #47823
Merged
MacJoom merged 3 commits intoMay 24, 2026
Merged
Conversation
…and compile in plg_system_codemirror Co-authored-by: Christian Heel <66922325+heelc29@users.noreply.github.com>
LadySolveig
marked this pull request as ready for review
May 24, 2026 12:17
Member
|
I have tested this item ✅ successfully on 9de1cb3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47823. |
3 of 5 tasks
tecpromotion
approved these changes
May 24, 2026
Contributor
|
I have tested this item ✅ successfully on 9de1cb3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47823. |
Member
|
Thank you all - authors, reviewers and testers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request resolves ##47794 (comment) .
Summary of Changes
This pull request makes a small update to the
CodemirrorModuleBuilderclass to fix the vendor path for CodeMirror dependencies. The new path points to the correct directory where the CodeMirror JavaScript files are located.Testing Instructions
run
npm ciActual result BEFORE applying this Pull Request
Wrong targetPath:
media/plg_editors_codemirror/js/LICENSEExpected result AFTER applying this Pull Request
Right targetPath:
media/vendor/codemirror/LICENSELink to documentations
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Thanks for bringing this up and for your support @heelc29