Repository navigation
[6.2] Extensions Install: Upload from File: Associate upload limit with Upload & Install button - #48452
Conversation
Updates default.php to allow assistive technology to receive information about the file upload maximum size without needing to move focus away from the "Upload and Install" button.
|
@mbeganyi-a11y please check your work to make sure it does what you think it will do before submitting a PR - this can not do what you intend it to do at all - you can not have tested it |
I’ve just had a look at it myself, and @brianteeman is right. The code is neither correct nor tested. What’s more, it’s actually more of a feature than a bug, which means it belongs in 6.3-dev. |
|
@mbeganyi-a11y You made the change for the legacy upload button and not for the usual one. So this is only working in some circumstances. |
|
not even sure if that code is ever used anywhere |
|
Look as it is used when upload is in non form context. Seems like a left over from the last century. |
|
And we never have non form upload do we? |
It is a hiden area with a form. This old and unused area should be removed from the layout. |
|
the code in this layout and the accompanying JS was for support in browsers that do not support FormData which Joomla no longer supports anyway https://caniuse.com/mdn-api_formdata I would do a PR to remove this code which will never be used but dont know which version to make it for or if this needs to be deprecated first (which seems pointless but the rules might require it) |
|
I suggest a PR for 6.3. There is no b/c break and deprecation is pointless. |
|
please target 7.0, thanks |
|
thorium_yTivLfO4B0.mp4 |
|
You know what I never did in the last 12 years? Install from web ^^ |
|
OK this is all interesting and I'm glad to have...uh...partially solved something but not what I was aiming to solve. I will amend this PR to include the primary button and not only the one in the sidebar as Brian's video demonstrates. |
Targets correct button in the Extensions installer instead of legacy button used elsewhere in the interface.
|
no idea what i was thinking of #48452 (comment) just ignore that comment it was garbage |
|
irrelevant of my mistaken comment @mbeganyi-a11y you still can not have tested this PR as it would have been impossible for you to have tested the changes you have made in the hidden form |
|
In my haste I forgot to revert the initial commit, which I will do now. Thus this PR will only target the intended "Or browse for file" button in the "Upload Package File" tab of the Extension Installer. |
Reversion of initial commit that targeted the wrong HTML.
|
I have tested this item ✅ successfully on af181e3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48452. |
Removed blank space in element structure.
|
I have tested this item ✅ successfully on 5b24ce6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48452. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48452. |
|
Tested with NVDA ✔️ I wonder if the button should be changed from "Or browse for file" to just "Browse for file" It only makes sense to have "or" if you can see and read "Drag and drop file here to upload. Or browse for file" |
|
@brianteeman should we open a new PR/Issue/discussion about the wording, seems to me out of scope of this PR |
|
To me it's all the same problem. Not even sure if the first sentence should be hidden from screen readers. |
Interesting. I tested with Narrator on Windows 10 and got the announcement in Edge, Firefox, and Chrome. Not sure your setup but that's strange. Narrator can be finicky. I'm glad NVDA works though. Regarding the text change, screen reader users often navigate using the arrow keys, so finding that text above the button isn't impossible. If wanting to change it, moving the "or" from the control to the text preceding the button would be fine. As long as the core meaning of the control isn't affected, we're safe. |
only if they know there is text present personally I would remove the OR completely as its redundant text |
…ible button label This is an English source-label update for the package installer file-picker button to reflect a change in the visible text label.
Screen reader users often explore pages using arrow keys as not everything is revealed when pressing only the Tab key. I've updated the .ini file to remove the word "Or". This is an English-only change, and given that I'm not intimately familiar with the translation workflow, I'm hoping this is sufficient to cover other languages as well. Please advise if I'm mistaken. |
|
tested again with windows narrator and it still doesnt announce the aria-described by This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48452. |
|
Thanks |
Updates the default.php of the Extension Installer to allow assistive technology to receive information about the file upload maximum size without needing to move focus away from the "Upload and Install" button.
Pull Request resolves #48393.
Summary of Changes
Associates the maximum extension package upload size with the Upload & Install button in the Extensions Install screen so that the maximum upload file size is conveyed to assistive technology without focus needing to move from the button..
The existing maximum upload size text is given an ID and is referenced by the button using
aria-describedby.Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
When the Upload & Install button receives focus, a screen reader announces the maximum upload size information in addition to the button label.
Link to documentations
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed