Skip to content

[6.2] Extensions Install: Upload from File: Associate upload limit with Upload & Install button - #48452

Merged
drmenzelit merged 7 commits into
joomla:6.2-devfrom
mbeganyi-a11y:File-upload-limit-not-conveyed-(Extension-Installer)
Nov 5, 2026
Merged

drmenzelit merged 7 commits into
joomla:6.2-devfrom
mbeganyi-a11y:File-upload-limit-not-conveyed-(Extension-Installer)

Conversation

@mbeganyi-a11y

@mbeganyi-a11y mbeganyi-a11y commented Sep 13, 2026 •

Copy link
Copy Markdown
Collaborator

Updates the default.php of the Extension Installer to allow assistive technology to receive information about the file upload maximum size without needing to move focus away from the "Upload and Install" button.

Pull Request resolves #48393.

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

Associates the maximum extension package upload size with the Upload & Install button in the Extensions Install screen so that the maximum upload file size is conveyed to assistive technology without focus needing to move from the button..

The existing maximum upload size text is given an ID and is referenced by the button using aria-describedby.

Testing Instructions

  1. Log in to the Joomla administrator interface
  2. Navigate to System → Install → Extensions
  3. Open the Upload Package File tab
  4. Confirm the maximum upload-size text remains visibly displayed
  5. Start a screen reader (NVDA, JAWS, VoiceOver) and focus the "Or browse for file" button
  6. Confirm that the maximum upload size information is conveyed to assistive technology without needing to move focus away from the button

Actual result BEFORE applying this Pull Request

  1. The maximum upload size information is visible on screen, but it is not programmatically associated with the Upload & Install button, and
  2. A screen reader user can focus the button without the maximum permitted upload size being conveyed.

Expected result AFTER applying this Pull Request

When the Upload & Install button receives focus, a screen reader announces the maximum upload size information in addition to the button label.

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Updates default.php to allow assistive technology to receive information about the file upload maximum size without needing to move focus away from the "Upload and Install" button.
@brianteeman

Copy link
Copy Markdown
Contributor

@mbeganyi-a11y please check your work to make sure it does what you think it will do before submitting a PR - this can not do what you intend it to do at all - you can not have tested it

@tecpromotion

Copy link
Copy Markdown
Contributor

@mbeganyi-a11y please check your work to make sure it does what you think it will do before submitting a PR - this can not do what you intend it to do at all - you can not have tested it

I’ve just had a look at it myself, and @brianteeman is right. The code is neither correct nor tested.

What’s more, it’s actually more of a feature than a bug, which means it belongs in 6.3-dev.
I’d recommend that you close the PR and, if necessary, open a new, tested one for 6.3.

@rdeutz

rdeutz commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

@mbeganyi-a11y You made the change for the legacy upload button and not for the usual one. So this is only working in some circumstances.

@brianteeman

Copy link
Copy Markdown
Contributor

not even sure if that code is ever used anywhere

@rdeutz

rdeutz commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Look as it is used when upload is in non form context. Seems like a left over from the last century.

@brianteeman

Copy link
Copy Markdown
Contributor

And we never have non form upload do we?

@chmst chmst added a11y Accessibility a11y-priority-minor (Low) Issues with low priority labels Sep 14, 2026
@chmst

chmst commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

And we never have non form upload do we?

It is a hiden area with a form. This old and unused area should be removed from the layout.

@brianteeman

brianteeman commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

the code in this layout and the accompanying JS was for support in browsers that do not support FormData which Joomla no longer supports anyway https://caniuse.com/mdn-api_formdata

I would do a PR to remove this code which will never be used but dont know which version to make it for or if this needs to be deprecated first (which seems pointless but the rules might require it)

@chmst

chmst commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

I suggest a PR for 6.3. There is no b/c break and deprecation is pointless.

@HLeithner

Copy link
Copy Markdown
Member

please target 7.0, thanks

@brianteeman

brianteeman commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

SORRY - I was completely wrong - the code is used.

when you use the install from web option and click on install then this fieldset is displayed and used

thorium_yTivLfO4B0.mp4

@chmst

chmst commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

You know what I never did in the last 12 years? Install from web ^^

@mbeganyi-a11y

mbeganyi-a11y commented Sep 16, 2026 •

Copy link
Copy Markdown
Collaborator Author

OK this is all interesting and I'm glad to have...uh...partially solved something but not what I was aiming to solve.

I will amend this PR to include the primary button and not only the one in the sidebar as Brian's video demonstrates.

Targets correct button in the Extensions installer instead of legacy button used elsewhere in the interface.
@brianteeman

Copy link
Copy Markdown
Contributor

no idea what i was thinking of #48452 (comment) just ignore that comment it was garbage

@brianteeman

brianteeman commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

irrelevant of my mistaken comment @mbeganyi-a11y you still can not have tested this PR as it would have been impossible for you to have tested the changes you have made in the hidden form

@mbeganyi-a11y

Copy link
Copy Markdown
Collaborator Author

In my haste I forgot to revert the initial commit, which I will do now. Thus this PR will only target the intended "Or browse for file" button in the "Upload Package File" tab of the Extension Installer.

Reversion of initial commit that targeted the wrong HTML.
@rdeutz

rdeutz commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on af181e3

Tested with voice over on mac I can hear the additional information about the upload size.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48452.

Removed blank space in element structure.
@coolcat-creations

Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 5b24ce6

Tested Successfully the download size is now in the voiceover. Tested with VoiceOver on a Mac. Thank you for the PR!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48452.

@QuyTon

QuyTon commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48452.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 21, 2026
@mbeganyi-a11y
mbeganyi-a11y changed the base branch from 6.1-dev to 6.2-dev September 25, 2026 10:07
@mbeganyi-a11y mbeganyi-a11y changed the title [6.1] Extensions Install: Upload from File: Associate upload limit with Upload & Install button [6.2] Extensions Install: Upload from File: Associate upload limit with Upload & Install button Sep 25, 2026
@brianteeman

Copy link
Copy Markdown
Contributor

Tested with NVDA ✔️
Tested with Windows Narrator ✖️
That may be a narrator issue not a markup issue. Not all screen readers behave the same - tested with all levels of verbosity but the description is never announced.

I wonder if the button should be changed from "Or browse for file" to just "Browse for file"

It only makes sense to have "or" if you can see and read "Drag and drop file here to upload. Or browse for file"

@rdeutz

rdeutz commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

@brianteeman should we open a new PR/Issue/discussion about the wording, seems to me out of scope of this PR

@brianteeman

Copy link
Copy Markdown
Contributor

To me it's all the same problem. Not even sure if the first sentence should be hidden from screen readers.

@mbeganyi-a11y

Copy link
Copy Markdown
Collaborator Author

Tested with NVDA ✔️ Tested with Windows Narrator ✖️ That may be a narrator issue not a markup issue. Not all screen readers behave the same - tested with all levels of verbosity but the description is never announced.

I wonder if the button should be changed from "Or browse for file" to just "Browse for file"

It only makes sense to have "or" if you can see and read "Drag and drop file here to upload. Or browse for file"

Interesting. I tested with Narrator on Windows 10 and got the announcement in Edge, Firefox, and Chrome. Not sure your setup but that's strange. Narrator can be finicky. I'm glad NVDA works though.

Regarding the text change, screen reader users often navigate using the arrow keys, so finding that text above the button isn't impossible. If wanting to change it, moving the "or" from the control to the text preceding the button would be fine. As long as the core meaning of the control isn't affected, we're safe.

@brianteeman

Copy link
Copy Markdown
Contributor

Regarding the text change, screen reader users often navigate using the arrow keys, so finding that text above the button isn't impossible

only if they know there is text present

personally I would remove the OR completely as its redundant text

…ible button label

This is an English source-label update for the package installer file-picker button to reflect a change in the visible text label.
@joomla-cms-bot joomla-cms-bot added the Language Change This is for Translators label Oct 6, 2026
@mbeganyi-a11y

Copy link
Copy Markdown
Collaborator Author

Regarding the text change, screen reader users often navigate using the arrow keys, so finding that text above the button isn't impossible

only if they know there is text present

personally I would remove the OR completely as its redundant text

Screen reader users often explore pages using arrow keys as not everything is revealed when pressing only the Tab key.

I've updated the .ini file to remove the word "Or". This is an English-only change, and given that I'm not intimately familiar with the translation workflow, I'm hoping this is sufficient to cover other languages as well. Please advise if I'm mistaken.

@brianteeman

Copy link
Copy Markdown
Contributor

tested again with windows narrator and it still doesnt announce the aria-described by


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48452.

@drmenzelit
drmenzelit enabled auto-merge (squash) November 5, 2026 07:50
@drmenzelit
drmenzelit merged commit 1864735 into joomla:6.2-dev Nov 5, 2026
56 checks passed
@drmenzelit

Copy link
Copy Markdown
Contributor

Thanks

@richard67 richard67 removed the RTC This Pull Request is Ready To Commit label Nov 6, 2026
@richard67 richard67 added this to the Joomla! 6.2.1 milestone Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a11y Accessibility a11y-priority-minor (Low) Issues with low priority Language Change This is for Translators PR-6.2-dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Atum Extensions Install: File upload limit is not associated with upload button