Repository navigation
[6.2] [AI] Fix Associations::getAssociations() returning the requested item itself - #48574
Merged
MacJoom merged 2 commits intoOct 5, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
I have tested this item ✅ successfully on 8d77759 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48574. |
Member
|
I have tested this item ✅ successfully on 8d77759 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48574. |
Contributor
|
RTC |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request resolves # .
Summary of Changes
PR #39189 added support for passing an array of IDs to
Associations::getAssociations(). Since then the check "Do not return itself as result" no longer works in two cases:$id, which is an array, so the comparison is always true. The fix compares it with the requested ID of the current row ($item->pk).$id = (int) $id;cast, so a strict comparison with a numeric string (e.g.'5') is always true. The fix casts$idin the comparison.In both cases the requested item was returned as its own association.
Testing Instructions
5in the example below).index.phpof the frontend template (replace5with your ID) and open the frontend:Actual result BEFORE applying this Pull Request
Both calls return
en-GBandde-DE, so the requested article is listed as its own association.Expected result AFTER applying this Pull Request
Both calls return only
de-DE.Link to documentations
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
🤖 Generated with Claude Code