Repository navigation
[6.2] Move search filter label in admin list views [a11y] - #48707
Merged
Merged
Conversation
|
I have tested this item ✅ successfully on 0fe05e8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48707. |
Contributor
|
I have tested this item ✅ successfully on 0fe05e8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48707. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48707. |
Contributor
|
Thanks |
Contributor
Author
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request resolves # .
Summary of Changes
This really is a pointless PR as its just making a change to satisfy an accessibility checker but I am told that its still good to solve it even if its just to satisfy a test - there is no visual difference and there is no difference in a screenreader (tested with NVDA and Narrator) but the IBM accessibility checker complains about it so I am fixing it to reduce the noise in the checker - maybe other screenreaders report differently
all it does is to move the label (screen reader only) for the search input to be placed before the input and not afterwards
Testing Instructions
If you have the IBM Accessibility Equal Access Toolkit: Accessibility Checker installed in your browser then you can check any list page in the Joomla admin that has a search box using that checker. The smart search filters page is a good one to test with as there is not much on the page.
Actual result BEFORE applying this Pull Request
two violations - this pr is for the 2nd one
Expected result AFTER applying this Pull Request
only one violation
Link to documentations
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed