Skip to content

[6.2] Move search filter label in admin list views [a11y] - #48707

Merged
drmenzelit merged 3 commits into
joomla:6.2-devfrom
brianteeman:search_filter_label
Oct 30, 2026
Merged

drmenzelit merged 3 commits into
joomla:6.2-devfrom
brianteeman:search_filter_label

Conversation

@brianteeman

@brianteeman brianteeman commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Pull Request resolves # .

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

This really is a pointless PR as its just making a change to satisfy an accessibility checker but I am told that its still good to solve it even if its just to satisfy a test - there is no visual difference and there is no difference in a screenreader (tested with NVDA and Narrator) but the IBM accessibility checker complains about it so I am fixing it to reduce the noise in the checker - maybe other screenreaders report differently

all it does is to move the label (screen reader only) for the search input to be placed before the input and not afterwards

Testing Instructions

If you have the IBM Accessibility Equal Access Toolkit: Accessibility Checker installed in your browser then you can check any list page in the Joomla admin that has a search box using that checker. The smart search filters page is a good one to test with as there is not much on the page.

Actual result BEFORE applying this Pull Request

two violations - this pr is for the 2nd one

image

Expected result AFTER applying this Pull Request

only one violation

image

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@richard67 richard67 changed the title [6.2]Move search filter label in admin list views [a11y] [6.2] Move search filter label in admin list views [a11y] Oct 26, 2026
@exlemor

exlemor commented Oct 26, 2026

Copy link
Copy Markdown

I have tested this item ✅ successfully on 0fe05e8

I installed the IBM Equal Access Accessibility Checker which I discovered thanks to you. I was able to successfully test this PR. Thanks @brianteeman.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48707.

@richard67 richard67 added the a11y Accessibility label Oct 27, 2026
@chmst

chmst commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 0fe05e8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48707.

@chmst chmst removed a11y Accessibility PR-6.2-dev labels Oct 27, 2026
@chmst

chmst commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48707.

@joomla-cms-bot joomla-cms-bot added PR-6.2-dev RTC This Pull Request is Ready To Commit labels Oct 27, 2026
@richard67 richard67 added the a11y Accessibility label Oct 27, 2026
@drmenzelit
drmenzelit merged commit be334f1 into joomla:6.2-dev Oct 30, 2026
56 checks passed
@drmenzelit

Copy link
Copy Markdown
Contributor

Thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 30, 2026
@brianteeman
brianteeman deleted the search_filter_label branch October 30, 2026 13:27
@brianteeman

Copy link
Copy Markdown
Contributor Author

thanks

@drmenzelit drmenzelit added this to the Joomla! 6.2.1 milestone Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a11y Accessibility PR-6.2-dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants