Repository navigation
[6.2] translatable aria-label for search module [a11y] - #48766
Merged
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on 83deb26 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48766. |
Contributor
|
I have tested this item ✅ successfully on 83deb26 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48766. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48766. |
drmenzelit
approved these changes
Nov 4, 2026
Contributor
Author
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request resolves #48765 .
Summary of Changes
replaces hard coded english language "search" for the aria-label with a translatable string
Testing Instructions
Apply the PR and publish the smart search module
Check the source and you will find an aria-label on the form element
Actual result BEFORE applying this Pull Request
aria-label="search"
Expected result AFTER applying this Pull Request
aria-label="Search"
The capital shows you it is coming from the new language file
Link to documentations
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed