Skip to content

[6.2] translatable aria-label for search module [a11y] - #48766

Merged
drmenzelit merged 2 commits into
joomla:6.2-devfrom
brianteeman:mod_finder
Nov 4, 2026
Merged

drmenzelit merged 2 commits into
joomla:6.2-devfrom
brianteeman:mod_finder

Conversation

@brianteeman

@brianteeman brianteeman commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Pull Request resolves #48765 .

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

replaces hard coded english language "search" for the aria-label with a translatable string

Testing Instructions

Apply the PR and publish the smart search module

Check the source and you will find an aria-label on the form element

Actual result BEFORE applying this Pull Request

aria-label="search"

Expected result AFTER applying this Pull Request

aria-label="Search"

The capital shows you it is coming from the new language file

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@brianteeman
brianteeman requested a review from chmst as a code owner November 3, 2026 17:07
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-6.2-dev labels Nov 3, 2026
@brianteeman brianteeman changed the title [6.2]translatable aria-label for search module [6.2]translatable aria-label for search module [a11y] Nov 3, 2026
@tecpromotion tecpromotion changed the title [6.2]translatable aria-label for search module [a11y] [6.2] translatable aria-label for search module [a11y] Nov 3, 2026
@tecpromotion tecpromotion added the a11y Accessibility label Nov 3, 2026
@tecpromotion

Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 83deb26


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48766.

@QuyTon

QuyTon commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 83deb26


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48766.

@QuyTon

QuyTon commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48766.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 3, 2026
@drmenzelit drmenzelit added this to the Joomla! 6.2.1 milestone Nov 4, 2026
@drmenzelit
drmenzelit enabled auto-merge (squash) November 4, 2026 17:54
@drmenzelit
drmenzelit merged commit 9bbc691 into joomla:6.2-dev Nov 4, 2026
56 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 4, 2026
@brianteeman
brianteeman deleted the mod_finder branch November 4, 2026 18:19
@brianteeman

Copy link
Copy Markdown
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a11y Accessibility Language Change This is for Translators PR-6.2-dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[6.2] Finder module: form has unchangeable and untranslatable aria-label

5 participants