Skip to content
This repository was archived by the owner on Mar 29, 2026. It is now read-only.

Handle module __builtins__ both as dict or module - #1107

Merged
jopohl merged 5 commits into
jopohl:masterfrom
rffontenelle:handle_builtin_as_dict
Mar 15, 2024
Merged

jopohl merged 5 commits into
jopohl:masterfrom
rffontenelle:handle_builtin_as_dict

Conversation

@rffontenelle

@rffontenelle rffontenelle commented Mar 11, 2024 •

Copy link
Copy Markdown
Contributor

Fixes #1106

@CLAassistant

CLAassistant commented Mar 11, 2024 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@andynoack
andynoack requested a review from jopohl March 13, 2024 10:57
Comment thread setup.py Resolved
Co-authored-by: Dr. Johannes Pohl <Johannes.Pohl90@gmail.com>
@rffontenelle
rffontenelle requested a review from jopohl March 13, 2024 19:11

@jopohl jopohl left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Please just add a short comment (see below) and this is good to go.

Comment thread setup.py Resolved
Co-authored-by: Dr. Johannes Pohl <Johannes.Pohl90@gmail.com>
@rffontenelle

Copy link
Copy Markdown
Contributor Author

I see macOS keeps failing now and was not failing in other workflow runs, but I'm unable to find relation with this patch. Should we worry about it?

@jopohl

jopohl commented Mar 14, 2024

Copy link
Copy Markdown
Owner

Good catch. I just merged a fix for the macOS tests to master. Can you please merge it to your branch to ensure the CI is green afterwards?

@rffontenelle

rffontenelle commented Mar 14, 2024 •

Copy link
Copy Markdown
Contributor Author

Hmm I used GitHub sync fork button and a "merge" commit was added.

Want me to squash commits to keep git history clean? Alternatively, if you want it is possible to squash and merge once it is all good.

@jopohl

jopohl commented Mar 15, 2024

Copy link
Copy Markdown
Owner

All good, I'll just squash all your commits into one for clean history in URH. Thanks for working on this.

@jopohl
jopohl merged commit 2f565c7 into jopohl:master Mar 15, 2024
@rffontenelle
rffontenelle deleted the handle_builtin_as_dict branch April 18, 2024 22:13
dl1jbe pushed a commit to dl1jbe/urh that referenced this pull request Nov 15, 2025
dl1jbe pushed a commit to dl1jbe/urh that referenced this pull request Nov 15, 2025
dl1jbe pushed a commit to dl1jbe/urh that referenced this pull request Nov 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AttributeError: 'dict' object has no attribute '__NUMPY_SETUP__'

3 participants