Skip to content
This repository was archived by the owner on Mar 29, 2026. It is now read-only.

add default noise threshold setting - #949

Merged
jopohl merged 2 commits into
masterfrom
default_noise_setting
Feb 22, 2022
Merged

jopohl merged 2 commits into
masterfrom
default_noise_setting

Conversation

@jopohl

@jopohl jopohl commented Feb 22, 2022 •

Copy link
Copy Markdown
Owner

This PR adds a new setting for the default noise threshold to the main menu:
image

The current behavior is reached with the default setting "automatic" - the new settings allow skipping the automatic noise detection to speed up loading of big signals.

This also fixes #928 as setting the noise threshold to 100% will disable demodulation.

@jopohl jopohl added the feature label Feb 22, 2022
@jopohl jopohl self-assigned this Feb 22, 2022
@jopohl
jopohl requested a review from andynoack February 22, 2022 19:53
@andynoack

Copy link
Copy Markdown
Collaborator

The code seems legit. I did not find any problems.

@jopohl
jopohl merged commit 02183da into master Feb 22, 2022
@jopohl
jopohl deleted the default_noise_setting branch February 22, 2022 20:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: Option to deactivate "Show Signal as" checkbox (e.g. when loading a file)

2 participants