This repository was archived by the owner on Mar 29, 2026. It is now read-only.
Repository navigation
add default noise threshold setting - #949
Merged
Merged
Conversation
Collaborator
|
The code seems legit. I did not find any problems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new setting for the default noise threshold to the main menu:

The current behavior is reached with the default setting "automatic" - the new settings allow skipping the automatic noise detection to speed up loading of big signals.
This also fixes #928 as setting the noise threshold to 100% will disable demodulation.