Repository navigation
fix(installer): offer only the extensions this node can install - #5117
Merged
mudler merged 1 commit intoOct 2, 2026
Merged
Conversation
The extension step listed every layer the catalog indexes. A layer does not have to publish a system extension image: hadron-layers turns the extension build off per layer through publishing.yaml, and a newly added layer is indexed before its first extension is pushed. Selecting such an entry wrote an install.extensions name the agent then refused, after the operator had confirmed the install. `git` is in that state today. Offer a catalog layer only when the agent's own resolver can resolve its name with no version, for the architecture the installer runs on. Reusing the resolver keeps the menu from drifting from what the install will do, and drops the entry rather than quietly offering it at an older version, which kairos-io#4718 rejected. Say what is wrong when a version publishes no image at all, rather than naming an architecture that would not have helped. Fixes kairos-io#5116 Signed-off-by: Ettore Di Giacinto <mudler@kairos.io>
ci-robbot
temporarily deployed
to
fork-pr-builds
October 1, 2026 19:20 — with
GitHub Actions
Inactive
mudler
approved these changes
Oct 1, 2026
Collaborator
Author
|
QA verdict for this head ( |
This was referenced Oct 4, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5116
Summary
The interactive installer's extension step listed every layer the catalog
indexes, including layers that publish no system extension image. Selecting one
wrote an
install.extensionsname that the agent then refused, after theoperator had confirmed the install.
gitis in exactly that state on thepublished hadron-layers index today:
publishing.yamlskips its sysext buildon purpose, so the index carries it with
"sysext": {}on every tag, and thisrepository already vendors the proof in
sdk/extensions/testdata/releases.json.The screen now offers a catalog layer only when the agent's own resolver can
resolve that name with no version, for the architecture the installer is
running on. Reusing the resolver is what keeps the menu from drifting from what
the install will do, and it drops the entry rather than quietly offering it at
an older version, which #4718 rejected. This moves the same failure earlier, it
does not add a fallback.
Second half: when a version publishes no extension image at all,
Catalog.Resolvenow says so. It used to reportarchitecture "amd64" is not available for layer "git" version "2.56.0", which sends the reader looking fora node of another architecture when none would work.
How it was tested
go test ./sdk/extensions/... ./agent/pkg/extensions/... ./installer/... ./sdk/types/extensions/...is green.New specs, each confirmed to fail with the change backed out and to pass with
it in:
sysextobject is not offeredarm64only is not offered onamd64, and is offeredon
arm64is unaffected
Catalog.Resolveon a base-only layer says the layer publishes no image, anddoes not name the architecture
One existing fixture had to be corrected on the way:
catalogJSONin the wizardtests used tag references (
...tailscale:1.80.0) where the generator and theresolver both require a digest. Nothing had run it through
Resolvebefore, sothe fixture described a catalog the agent would have refused.
The GHCR state quoted in the issue was read anonymously from the registry
during this session:
Not booted. This is installer-side selection logic covered by unit tests; the
install path it feeds is unchanged.
AI wrote this change. No human read it before it was opened.
π€ Generated with Claude Code