Skip to content

ci: scope reusable-factory token and stop releasing the test-key-signed FIPS UKI - #5259

Merged
Itxaka merged 2 commits into
masterfrom
fix/reusable-factory-permissions
Oct 7, 2026
Merged

Itxaka merged 2 commits into
masterfrom
fix/reusable-factory-permissions

Conversation

@jimmykarily

@jimmykarily jimmykarily commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Two workflow fixes from the OpenSSF Baseline work in #3753.

1. ci(factory): declare empty top-level permissions on reusable-factory

It was the only workflow without a top-level permissions: block, so any job added without its own block would inherit the repository default token scope. Scorecard's Token-Permissions check scores it 0 for this. The single job already declares everything it needs at job level; internal/ciguard still passes.

2. ci(release): stop releasing the FIPS UKI ISO signed with CI test keys

3966597e added an amd64-core-fips-uki cell to the release matrix. _build-iso.yaml signs every trusted boot build with tests/assets/keys, whose private keys are in this public repository (self-signed, expired 2025-06-10), so the next release would have shipped a UKI ISO whose Secure Boot signature proves nothing about who built it. That is the reason 07d67a55 dropped the other UKI artifacts from releases. No published release carries a UKI ISO yet (checked v4.0.0 through v4.3.0), so nothing shipped with it.

This removes the cell. It also unblocks removing the committed test keys, which #3753 needs for OSPS-QA-05. Official trusted boot images signed with a real Kairos key are #4054.

Testing: make lint-workflows, make test.

Part of #3753

Written with AI assistance (Claude Code). Human review of the code is still pending.

πŸ€– Generated with Claude Code

@jimmykarily jimmykarily changed the title ci(factory): declare empty top-level permissions on reusable-factory ci: scope reusable-factory token and stop releasing the test-key-signed FIPS UKI Oct 6, 2026
@jimmykarily
jimmykarily force-pushed the fix/reusable-factory-permissions branch from bb24403 to 436a267 Compare October 6, 2026 10:27
@jimmykarily
jimmykarily requested a balanced review from Copilot October 7, 2026 11:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟑 Changes recommended

The release guard accepts boolean expressions that enable trusted boot without reporting an offending build.

Review effort: Balanced
Findings: 1 High severity

Open (1)
What changed in this PR

Hardens Kairos release workflows as part of the OpenSSF Baseline work.

Changes:

  • Sets empty default token permissions for the reusable factory workflow.
  • Removes the FIPS trusted-boot release cell signed with public test keys.
  • Adds a guard against trusted-boot release builds.
File Description
internal/​ciguard/​release_test.go Adds the release configuration guard.
.github/​workflows/​reusable-factory.yaml Restricts default token permissions.
.github/​workflows/​release.yaml Removes the FIPS UKI cell and documents why.

πŸ’‘ Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread internal/ciguard/release_test.go Resolved
jimmykarily and others added 2 commits October 7, 2026 14:22
It was the only workflow without a top-level permissions block, so any
job added without its own block would inherit the repository default
token scope. Scorecard's Token-Permissions check scores it 0 for this.

Part of #3753

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
The amd64-core-fips-uki cell signed its UKI with tests/assets/keys,
whose private keys are public, the same reason the other UKI artifacts
were dropped from releases.

Part of #3753

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
@jimmykarily
jimmykarily force-pushed the fix/reusable-factory-permissions branch from 436a267 to 5b4c33e Compare October 7, 2026 11:22
@jimmykarily
jimmykarily marked this pull request as ready for review October 7, 2026 11:22
@jimmykarily
jimmykarily requested a review from a team as a code owner October 7, 2026 11:22
@jimmykarily jimmykarily self-assigned this Oct 7, 2026
@mauromorales

Copy link
Copy Markdown
Member

@mauro-agent please review

@mauro-agent

Copy link
Copy Markdown
Contributor

⏳ Work claimed by mauro-agent, an AI agent operated by @mauromorales, at 2026-10-07T11:34:05Z. If you are another lane about to start substantial work here, please check for a follow-up comment before duplicating it -- this marker exists specifically to prevent two lanes from independently doing the same work.

@Itxaka
Itxaka merged commit 1ba57e2 into master Oct 7, 2026
28 checks passed
@Itxaka
Itxaka deleted the fix/reusable-factory-permissions branch October 7, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants