Repository navigation
ci: scope reusable-factory token and stop releasing the test-key-signed FIPS UKI - #5259
Merged
Merged
Conversation
This was referenced Oct 6, 2026
jimmykarily
force-pushed
the
fix/reusable-factory-permissions
branch
from
October 6, 2026 10:27
bb24403 to
436a267
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
π‘ Changes recommended
The release guard accepts boolean expressions that enable trusted boot without reporting an offending build.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Hardens Kairos release workflows as part of the OpenSSF Baseline work.
Changes:
- Sets empty default token permissions for the reusable factory workflow.
- Removes the FIPS trusted-boot release cell signed with public test keys.
- Adds a guard against trusted-boot release builds.
| File | Description |
|---|---|
internal/βciguard/βrelease_test.go |
Adds the release configuration guard. |
.github/βworkflows/βreusable-factory.yaml |
Restricts default token permissions. |
.github/βworkflows/βrelease.yaml |
Removes the FIPS UKI cell and documents why. |
π‘ Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
It was the only workflow without a top-level permissions block, so any job added without its own block would inherit the repository default token scope. Scorecard's Token-Permissions check scores it 0 for this. Part of #3753 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
The amd64-core-fips-uki cell signed its UKI with tests/assets/keys, whose private keys are public, the same reason the other UKI artifacts were dropped from releases. Part of #3753 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
jimmykarily
force-pushed
the
fix/reusable-factory-permissions
branch
from
October 7, 2026 11:22
436a267 to
5b4c33e
Compare
jimmykarily
marked this pull request as ready for review
October 7, 2026 11:22
Member
|
@mauro-agent please review |
mauromorales
approved these changes
Oct 7, 2026
Contributor
|
β³ Work claimed by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Two workflow fixes from the OpenSSF Baseline work in #3753.
1.
ci(factory): declare empty top-level permissions on reusable-factoryIt was the only workflow without a top-level
permissions:block, so any job added without its own block would inherit the repository default token scope. Scorecard's Token-Permissions check scores it 0 for this. The single job already declares everything it needs at job level;internal/ciguardstill passes.2.
ci(release): stop releasing the FIPS UKI ISO signed with CI test keys3966597eadded anamd64-core-fips-ukicell to the release matrix._build-iso.yamlsigns every trusted boot build withtests/assets/keys, whose private keys are in this public repository (self-signed, expired 2025-06-10), so the next release would have shipped a UKI ISO whose Secure Boot signature proves nothing about who built it. That is the reason07d67a55dropped the other UKI artifacts from releases. No published release carries a UKI ISO yet (checked v4.0.0 through v4.3.0), so nothing shipped with it.This removes the cell. It also unblocks removing the committed test keys, which #3753 needs for OSPS-QA-05. Official trusted boot images signed with a real Kairos key are #4054.
Testing:
make lint-workflows,make test.Part of #3753
Written with AI assistance (Claude Code). Human review of the code is still pending.
π€ Generated with Claude Code