Repository navigation
ci: audit the workflows with zizmor - #5319
Merged
Merged
Conversation
zizmor checks the workflow files for template injection, persisted credentials, inherited secrets and dangerous triggers. The job fails on findings but is not required, and master also uploads them to the Security tab. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
GitHub only runs workflows from the repository root, so the copies under immucore, sdk and kairos-init stopped running at the monorepo migration. They still show up in workflow scanners such as zizmor. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Contributor
There was a problem hiding this comment.
π’ Approval recommended
The implementation is sound, with only a minor documentation correction needed for GitHub's annotation limit.
1 open finding
What changed in this PR
Adds a pinned zizmor security audit for GitHub Actions and removes obsolete nested workflows.
Changes:
- Adds annotation and SARIF audit jobs.
- Adds Renovate tracking for zizmor.
- Removes workflows inactive since the monorepo migration.
| File | Description |
|---|---|
.github/βworkflows/βzizmor.yaml |
Adds zizmor audit jobs. |
renovate.json |
Tracks the pinned zizmor version. |
sdk/β.github/βworkflows/βunit-tests.yml |
Removes obsolete SDK tests workflow. |
sdk/β.github/βworkflows/βsecscan.yaml |
Removes obsolete SDK security scan. |
sdk/β.github/βworkflows/βrenovate_auto.yml |
Removes obsolete SDK Renovate automation. |
sdk/β.github/βworkflows/βosv-scanner-pr.yaml |
Removes obsolete SDK dependency scan. |
sdk/β.github/βworkflows/βlint.yaml |
Removes obsolete SDK lint workflow. |
sdk/β.github/βworkflows/βdependabot_auto.yml |
Removes obsolete SDK Dependabot automation. |
kairos-init/β.github/βworkflows/βunit-test.yml |
Removes obsolete unit-test workflow. |
kairos-init/β.github/βworkflows/βtest.yml |
Removes obsolete image matrix. |
kairos-init/β.github/βworkflows/βrelease.yml |
Removes obsolete release workflow. |
kairos-init/β.github/βworkflows/βlint.yaml |
Removes obsolete lint workflow. |
kairos-init/β.github/βworkflows/βdocker.yml |
Removes obsolete image workflow. |
immucore/β.github/βworkflows/βunit-tests.yaml |
Removes obsolete unit-test workflow. |
immucore/β.github/βworkflows/βsecscan.yaml |
Removes obsolete security scan. |
immucore/β.github/βworkflows/βrelease.yaml |
Removes obsolete release workflow. |
immucore/β.github/βworkflows/βosv-scanner-pr.yaml |
Removes obsolete dependency scan. |
immucore/β.github/βworkflows/βlint.yaml |
Removes obsolete lint workflow. |
π§ Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Comment on lines
+7
to
+8
| # The `zizmor` job fails on any finding and reports each one as an | ||
| # annotation on the offending line. It is not a required check, so a |
mauromorales
approved these changes
Oct 8, 2026
This was referenced Oct 8, 2026
29 of 31 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds zizmor, a static security audit of the GitHub Actions workflows, for OSPS-BR-01 in #3753. This is the first of several pull requests: it adds the check, and the next ones fix what it reports.
What changes
.github/workflows/zizmor.yamlruns on pull requests and on pushes to master that touch.github/workflows/or.github/actions/:zizmoraudits the workflows, puts an annotation on each finding and fails if there is any. It is not a required check, so a red result does not block merging.zizmor-sarifruns on master only and sends the same findings to the Security tab. zizmor exits 0 in that mode, so the upload always happens.immucore/.github,sdk/.githubandkairos-init/.githubare removed. GitHub only runs workflows from the repository root, so they have not run since the monorepo migration, but scanners still read them. Before removing them I checked each one against what runs today. Lint, unit tests, the kairos-init image and release, the base OS image matrix and the dependency scan all have an equivalent. The only real loss is the race detector in the unit tests, which is being added back separately.Expected result
The zizmor check on this pull request is red. Excluding low-confidence results, it reports about 280 findings, to be fixed in follow-up pull requests:
${{ }}expanded straight intorun:scripts in the reusable workflows (none of them comes from outside the repository today);secrets: inheritinmaster.yaml,pr-full.yamlandrelease.yaml;persist-credentials);pull_request_targettrigger inpr-full.yamlandworkflow_runinupload-cloud-images.yaml, to be documented and suppressed with the reason;uses: $/...syntax for references within this repository.Testing
renovate-config-validator --strictpass.Part of #3753
Written with AI assistance (Claude Code). Human review of the code is still pending.
π€ Generated with Claude Code