Skip to content

ci: audit the workflows with zizmor - #5319

Merged
jimmykarily merged 2 commits into
masterfrom
ci/zizmor-audit
Oct 8, 2026
Merged

jimmykarily merged 2 commits into
masterfrom
ci/zizmor-audit

Conversation

@jimmykarily

@jimmykarily jimmykarily commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Adds zizmor, a static security audit of the GitHub Actions workflows, for OSPS-BR-01 in #3753. This is the first of several pull requests: it adds the check, and the next ones fix what it reports.

What changes

  • .github/workflows/zizmor.yaml runs on pull requests and on pushes to master that touch .github/workflows/ or .github/actions/:
    • zizmor audits the workflows, puts an annotation on each finding and fails if there is any. It is not a required check, so a red result does not block merging.
    • zizmor-sarif runs on master only and sends the same findings to the Security tab. zizmor exits 0 in that mode, so the upload always happens.
  • The action is pinned by commit and zizmor itself by version (1.30.1), so a new zizmor release cannot add findings overnight. A Renovate rule keeps that version current.
  • The workflows under immucore/.github, sdk/.github and kairos-init/.github are removed. GitHub only runs workflows from the repository root, so they have not run since the monorepo migration, but scanners still read them. Before removing them I checked each one against what runs today. Lint, unit tests, the kairos-init image and release, the base OS image matrix and the dependency scan all have an equivalent. The only real loss is the race detector in the unit tests, which is being added back separately.

Expected result

The zizmor check on this pull request is red. Excluding low-confidence results, it reports about 280 findings, to be fixed in follow-up pull requests:

  • values from ${{ }} expanded straight into run: scripts in the reusable workflows (none of them comes from outside the repository today);
  • secrets: inherit in master.yaml, pr-full.yaml and release.yaml;
  • checkouts that keep the token (persist-credentials);
  • the pull_request_target trigger in pr-full.yaml and workflow_run in upload-cloud-images.yaml, to be documented and suppressed with the reason;
  • two cache findings and the new uses: $/... syntax for references within this repository.

Testing

  • zizmor reports no findings on the new workflow, run locally with the same version.
  • actionlint, yamllint and renovate-config-validator --strict pass.
  • I ran zizmor locally in both modes: in SARIF mode it exits 0, with annotations it exits 14.

Part of #3753

Written with AI assistance (Claude Code). Human review of the code is still pending.

πŸ€– Generated with Claude Code

jimmykarily and others added 2 commits October 8, 2026 13:12
zizmor checks the workflow files for template injection, persisted
credentials, inherited secrets and dangerous triggers. The job fails on
findings but is not required, and master also uploads them to the
Security tab.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
GitHub only runs workflows from the repository root, so the copies
under immucore, sdk and kairos-init stopped running at the monorepo
migration. They still show up in workflow scanners such as zizmor.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
@jimmykarily
jimmykarily requested a review from a team as a code owner October 8, 2026 10:18
@jimmykarily jimmykarily self-assigned this Oct 8, 2026
@jimmykarily
jimmykarily requested a balanced review from Copilot October 8, 2026 10:24
@jimmykarily jimmykarily moved this to Under review πŸ” in πŸ§™Issue tracking board Oct 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟒 Approval recommended

The implementation is sound, with only a minor documentation correction needed for GitHub's annotation limit.

1 open finding
What changed in this PR

Adds a pinned zizmor security audit for GitHub Actions and removes obsolete nested workflows.

Changes:

  • Adds annotation and SARIF audit jobs.
  • Adds Renovate tracking for zizmor.
  • Removes workflows inactive since the monorepo migration.
File Description
.github/​workflows/​zizmor.yaml Adds zizmor audit jobs.
renovate.json Tracks the pinned zizmor version.
sdk/​.github/​workflows/​unit-tests.yml Removes obsolete SDK tests workflow.
sdk/​.github/​workflows/​secscan.yaml Removes obsolete SDK security scan.
sdk/​.github/​workflows/​renovate_auto.yml Removes obsolete SDK Renovate automation.
sdk/​.github/​workflows/​osv-scanner-pr.yaml Removes obsolete SDK dependency scan.
sdk/​.github/​workflows/​lint.yaml Removes obsolete SDK lint workflow.
sdk/​.github/​workflows/​dependabot_auto.yml Removes obsolete SDK Dependabot automation.
kairos-init/​.github/​workflows/​unit-test.yml Removes obsolete unit-test workflow.
kairos-init/​.github/​workflows/​test.yml Removes obsolete image matrix.
kairos-init/​.github/​workflows/​release.yml Removes obsolete release workflow.
kairos-init/​.github/​workflows/​lint.yaml Removes obsolete lint workflow.
kairos-init/​.github/​workflows/​docker.yml Removes obsolete image workflow.
immucore/​.github/​workflows/​unit-tests.yaml Removes obsolete unit-test workflow.
immucore/​.github/​workflows/​secscan.yaml Removes obsolete security scan.
immucore/​.github/​workflows/​release.yaml Removes obsolete release workflow.
immucore/​.github/​workflows/​osv-scanner-pr.yaml Removes obsolete dependency scan.
immucore/​.github/​workflows/​lint.yaml Removes obsolete lint workflow.

🧠 Review effort: Balanced


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

Comment on lines +7 to +8
# The `zizmor` job fails on any finding and reports each one as an
# annotation on the offending line. It is not a required check, so a
@jimmykarily
jimmykarily merged commit 09e852d into master Oct 8, 2026
30 of 31 checks passed
@jimmykarily
jimmykarily deleted the ci/zizmor-audit branch October 8, 2026 10:39
@github-project-automation github-project-automation Bot moved this from Under review πŸ” to Done βœ… in πŸ§™Issue tracking board Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants