Skip to content

Feat/customizable file upload config - #818

Merged
takatost merged 3 commits into
langgenius:mainfrom
MatriQ:feat/customizable-file-upload-config
Aug 16, 2023
Merged

takatost merged 3 commits into
langgenius:mainfrom
MatriQ:feat/customizable-file-upload-config

Conversation

@MatriQ

@MatriQ MatriQ commented Aug 12, 2023

Copy link
Copy Markdown
Contributor
  • Move UPLOAD_FILE_SIZE_LIMIT and UPLOAD_FILE_BATCH_LIMIT into env
  • Refactor file type file upload in frontend

image

@takatost
takatost requested review from JohnJyong and iamjoel August 12, 2023 15:55
@crazywoola
crazywoola requested a review from takatost August 13, 2023 12:10
@MatriQ
MatriQ force-pushed the feat/customizable-file-upload-config branch from d1cdd77 to 71ca625 Compare August 14, 2023 07:54
@crazywoola

Copy link
Copy Markdown
Member

Close #496

@takatost takatost left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@takatost
takatost merged commit 155a473 into langgenius:main Aug 16, 2023
@shaxiaozz

Copy link
Copy Markdown
Contributor

I added these two environment variables, UPLOAD_FILE_SIZE_LIMIT and UPLOAD_FILE_BATCH_LIMIT, under langgenius/dify-api container orchestration in docker-compose.yaml as follows:

version: '3.1'
services:
  # API service
  api:
    image: langgenius/dify-api:0.3.17
    restart: always
    environment:
      # Startup mode, 'api' starts the API server.
      MODE: api
      # The log level for the application. Supported values are `DEBUG`, `INFO`, `WARNING`, `ERROR`, `CRITICAL`
      LOG_LEVEL: INFO
      UPLOAD_FILE_SIZE_LIMIT: 150

And re-execute: "docker-compose up -d", found that the upload file size limit is still 15M

@MatriQ

MatriQ commented Aug 25, 2023

Copy link
Copy Markdown
Contributor Author

I added these two environment variables, UPLOAD_FILE_SIZE_LIMIT and UPLOAD_FILE_BATCH_LIMIT, under langgenius/dify-api container orchestration in docker-compose.yaml as follows:

version: '3.1'
services:
  # API service
  api:
    image: langgenius/dify-api:0.3.17
    restart: always
    environment:
      # Startup mode, 'api' starts the API server.
      MODE: api
      # The log level for the application. Supported values are `DEBUG`, `INFO`, `WARNING`, `ERROR`, `CRITICAL`
      LOG_LEVEL: INFO
      UPLOAD_FILE_SIZE_LIMIT: 150

And re-execute: "docker-compose up -d", found that the upload file size limit is still 15M

Weird, It works in my k8s.

@shaxiaozz

Copy link
Copy Markdown
Contributor

@MatriQ
I am also very surprised that the increase of environment variables still cannot lift the 15M file size limit. I don't know if there is a problem with my configuration

@shaxiaozz

Copy link
Copy Markdown
Contributor

@MatriQ
Should variables be added to this container: "langgenius/dify-api:0.3.17"

@MatriQ

MatriQ commented Aug 29, 2023

Copy link
Copy Markdown
Contributor Author

I am also very surprised that the increase of environment variables still cannot lift the 15M file size limit. I don't know if there is a problem with my configuration

I think it should be working for 0.3.17. Have you ever entered the container to check the env value?

@shaxiaozz

Copy link
Copy Markdown
Contributor

@MatriQ I'm very sorry, but my mirror is still using 0.3.14. I replaced it with 0.3.18 to be able to change the file max, thanks~

HuberyHuV1 pushed a commit to HuberyHuV1/dify that referenced this pull request Jul 22, 2024
@dosubot dosubot Bot added the dependencies Pull requests that update a dependency file label Apr 29, 2025
Ssazurov pushed a commit to Ssazurov/dify that referenced this pull request Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants