Skip to content

partialmsgs: PeerRequestsPartial means PeerRequestsPartial - #685

Merged
MarcoPolo merged 1 commit into
masterfrom
partial-msgs-requests-partial-interface
Mar 16, 2026
Merged

MarcoPolo merged 1 commit into
masterfrom
partial-msgs-requests-partial-interface

Conversation

@MarcoPolo

Copy link
Copy Markdown
Contributor

Do not also check if we support partial messages on the topic because we may not even be subscribed to that topic. The application will simply not use this if they don't support partial messages on this topic.

@MarcoPolo
MarcoPolo requested a review from sukunrt March 5, 2026 23:07

@sukunrt sukunrt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not also check if we support partial messages on the topic because we may not even be subscribed to that topic. The application will simply not use this if they don't support partial messages on this topic.

Can you add this to the method documentation?

Do not also check if we support partial messages on the topic because we
may not even be subscribed to that topic. The application will simply
not use this if they don't support partial messages on this topic.
@MarcoPolo
MarcoPolo force-pushed the partial-msgs-requests-partial-interface branch from df56ce7 to e30a1e0 Compare March 16, 2026 17:35
@MarcoPolo
MarcoPolo merged commit c945e5d into master Mar 16, 2026
7 checks passed
@MarcoPolo
MarcoPolo deleted the partial-msgs-requests-partial-interface branch March 16, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants