Repository navigation
gossipsub: clean peer gater stats on inbound close - #699
Merged
Merged
Conversation
sukunrt
approved these changes
May 11, 2026
| } | ||
|
|
||
| func (pg *peerGater) OnClosedIncomingStream(p peer.ID, _ protocol.ID) { | ||
| pg.removePeerStats(p, false) |
Member
There was a problem hiding this comment.
This feels like a NoOp to me as the underlying logic only decrements connected if outbound is true.
Is this intentional?
Contributor
Author
There was a problem hiding this comment.
The important part is this:
if st.connected == 0 {
delete(pg.peerStats, p)
}
Which will clear any state associate with the peerStats when the incoming stream is closed. This cleans up the case where we added some state due to a message on the incoming stream, but never had an outbound stream.
MarcoPolo
force-pushed
the
marco/fix-unwanted
branch
from
May 11, 2026 22:49
560b284 to
1c73fc4
Compare
MarcoPolo
force-pushed
the
marco/peer-gater-cleanup
branch
from
May 11, 2026 22:49
b6a0a39 to
998602b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.