Skip to content

ci: use go1.23, drop go1.21 - #2933

Merged
MarcoPolo merged 1 commit into
masterfrom
sukun/go-1.23
Aug 21, 2024
Merged

MarcoPolo merged 1 commit into
masterfrom
sukun/go-1.23

Conversation

@sukunrt

@sukunrt sukunrt commented Aug 21, 2024

Copy link
Copy Markdown
Member

No description provided.

@sukunrt
sukunrt marked this pull request as ready for review August 21, 2024 13:29
Comment thread p2p/net/nat/nat_test.go
Comment on lines +48 to +49
addr, _ := netip.AddrFromSlice(net.IPv4(1, 2, 3, 4))
require.Equal(t, netip.AddrPortFrom(addr, 1234), mapped)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go1.23 changed the behavior here. v4 addresses and v4in6 addresses no longer compare as equal.
golang/go#68113

@MarcoPolo
MarcoPolo merged commit f535990 into master Aug 21, 2024
sukunrt added a commit that referenced this pull request Aug 30, 2024
MarcoPolo pushed a commit that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants