Repository navigation
ci: use go1.23, drop go1.21 - #2933
Merged
Merged
Conversation
sukunrt
marked this pull request as ready for review
August 21, 2024 13:29
sukunrt
commented
Aug 21, 2024
Comment on lines
+48
to
+49
| addr, _ := netip.AddrFromSlice(net.IPv4(1, 2, 3, 4)) | ||
| require.Equal(t, netip.AddrPortFrom(addr, 1234), mapped) |
Member
Author
There was a problem hiding this comment.
go1.23 changed the behavior here. v4 addresses and v4in6 addresses no longer compare as equal.
golang/go#68113
MarcoPolo
approved these changes
Aug 21, 2024
sukunrt
added a commit
that referenced
this pull request
Aug 30, 2024
MarcoPolo
pushed a commit
that referenced
this pull request
Sep 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.