Skip to content

fix(tcpreuse): remove windows specific code - #3039

Merged
MarcoPolo merged 2 commits into
masterfrom
marco/tcpreuse-windows
Nov 21, 2024
Merged

MarcoPolo merged 2 commits into
masterfrom
marco/tcpreuse-windows

Conversation

@MarcoPolo

@MarcoPolo MarcoPolo commented Nov 13, 2024 •

Copy link
Copy Markdown
Collaborator

Unclear why, but this causes a lot of CPU usage according to @aschmahmann

I wonder if we are spinning in the for loop. Is it possible the Windows api returns no bytes read and no error?

@MarcoPolo

Copy link
Copy Markdown
Collaborator Author

need to debug the failing test still

@MarcoPolo

Copy link
Copy Markdown
Collaborator Author

just an incomplete read in the test. Not a real issue.

@MarcoPolo
MarcoPolo force-pushed the marco/tcpreuse-windows branch from 332f113 to 5d36189 Compare November 14, 2024 21:13
@MarcoPolo MarcoPolo self-assigned this Nov 18, 2024
@MarcoPolo MarcoPolo changed the title fix: tcpreuse: remove windows specific code fix(tcpreuse): remove windows specific code Nov 18, 2024
Unclear why, but this causes a lot of CPU usage according to
@aschmahmann
@MarcoPolo
MarcoPolo force-pushed the marco/tcpreuse-windows branch from 5d36189 to cfa8b3b Compare November 18, 2024 22:39
@MarcoPolo

MarcoPolo commented Nov 21, 2024 •

Copy link
Copy Markdown
Collaborator Author

Merging since this may be related to the test failures in #3036

@MarcoPolo
MarcoPolo merged commit 1c9e5a1 into master Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant