Skip to content

fix(sampledconn): Correctly handle slow bytes and closed conns - #3080

Merged
sukunrt merged 11 commits into
masterfrom
marco/fix-spin
Dec 10, 2024
Merged

sukunrt merged 11 commits into
masterfrom
marco/fix-spin

Conversation

@MarcoPolo

Copy link
Copy Markdown
Collaborator

No description provided.

@MarcoPolo

Copy link
Copy Markdown
Collaborator Author

Currently investigating why linux fails here.

Not worth fiddling with the OS api right now
@MarcoPolo

Copy link
Copy Markdown
Collaborator Author

I've removed the OS specific things. The wrapper approach works fine and avoids a lot of complexity.

@MarcoPolo
MarcoPolo requested a review from sukunrt December 6, 2024 20:57
assert.Equal(t, "hello", string(buf))
} else {
// Wrap the client connection in SampledConn
sample, sampledConn, err := newFallbackSampledConn(clientConn.(ManetTCPConnInterface))

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we rename fallbackPeekingConn to sampledConn?

lidel added a commit to ipfs/kubo that referenced this pull request Dec 10, 2024
@sukunrt
sukunrt merged commit 4e85c96 into master Dec 10, 2024
@lidel lidel mentioned this pull request Dec 10, 2024
51 of 60 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants