Skip to content

Using syscall.RtMsg on Linux - #43

Merged
willscott merged 1 commit into
libp2p:masterfrom
7sunarni:master
Feb 27, 2024
Merged

willscott merged 1 commit into
libp2p:masterfrom
7sunarni:master

Conversation

@7sunarni

@7sunarni 7sunarni commented Feb 26, 2024 •

Copy link
Copy Markdown
Contributor

I think we don't need to define struct routeInfoInMemory because there is already defined struct sycall.RtMsg in Golang standard library

@7sunarni

Copy link
Copy Markdown
Contributor Author

@willscott

@willscott

Copy link
Copy Markdown
Contributor

I think this would mean the library couldn't be used on arm devices, right? - I see RtMsg in the arm64 types, but it isn't there for the arm definitions that would be used for e.g. older raspberry pi's / other armv6/armv7 chips.

I appreciate the simplification - are there other benefits to consider in whether it's worth using the partial upstream definition?

@7sunarni

Copy link
Copy Markdown
Contributor Author

I think this would mean the library couldn't be used on arm devices, right? - I see RtMsg in the arm64 types, but it isn't there for the arm definitions that would be used for e.g. older raspberry pi's / other armv6/armv7 chips.

I think you may miss something. There is also RtMsg definition in arm. So i think it could run in other arm chips.

are there other benefits to consider in whether it's worth using the partial upstream definition?

Temporary no.

@willscott

Copy link
Copy Markdown
Contributor

you're right! my search missed the arm one. this seems unobjectionable πŸ‘

@willscott
willscott merged commit 57cc4df into libp2p:master Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants