Repository navigation
fix: enable codegen feature for rust-i18n-support in dev-dependencies - #141
Merged
Merged
Conversation
…pport serde_yaml, toml, globwalk, normpath, itertools, serde_json, and serde are only needed during code generation (proc-macro / CLI), not at runtime. Moving them behind an optional `codegen` feature removes them from the user's final binary by default. Also removes three unused dependencies from rust-i18n-support (proc-macro2, regex, lazy_static). A new `load-path` feature on the root crate re-enables `try_load_locales` for users who need runtime locale file loading.
`load_locales` was gated behind the `codegen` feature in commit 2a60d99, breaking the integration test that imports it directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
serde,serde_yaml,globwalk, etc.) behind thecodegenfeature inrust-i18n-support, so downstream crates that don't useload-pathno longer compile them unnecessarily.load-pathfeature documentation to the README.load_localesis now gated behindcodegen, so the integration test that imports it directly needsrust-i18n-supportlisted in[dev-dependencies]withfeatures = ["codegen"].Test plan
cargo testpasses locally🤖 Generated with Claude Code