Repository navigation
[LOW] Remove vulnerable docs preview dependencies - #1714
Merged
olleolleolle merged 2 commits intoSep 16, 2026
Merged
Conversation
olleolleolle
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the local documentation preview server from
docsify-cli4.4.4 to 5.0.0 and refresh its lockfile to remove the currently reported transitive advisories.The old lock resolved 208 packages and
npm auditreported nine advisories (seven moderate, two high), includingmarkedregex denial of service andwsfragment-driven memory exhaustion. The refreshed graph contains 122 packages, pins the fixedws7.5.11, and reports zero known vulnerabilities.Verification
npm ci --ignore-scripts: 122 packages installed from the refreshed lockfile.npm audit: zero vulnerabilities.npm run docs -- --port 4568: local preview server started successfully.curlsmoke check retrieved the Faraday documentation page and expected title/core script.git diff --checkpasses.No production service, release workflow, or credential was used.
Scope and limitations
This tool is used only by the local
npm run docspreview command and is not packaged in the Faraday gem or executed by CI/release workflows. The upstream 5.0.0 release was published on 2026-07-29, more than a month before this change.Breaking-change notes
docsify-cli5 requires Node.js >= 20.11.0. The verification used Node 22.23.2. Maintainers using an older Node release will need to upgrade Node to run the local docs preview command; gem consumers are unaffected.