Repository navigation
Honor skip_libs in get_max_calls_to() for CallsTo scoring - #1242
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an inconsistency in how Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly implements the skip_libs parameter in get_max_calls_to by filtering out library functions, which was previously a TODO. This change will improve the quality of the CallsTo scoring heuristic. I've added one comment regarding a potential runtime error that this change makes more likely to occur.
|
thanks! |
Fixes:
flare-floss/floss/identify.py
Lines 69 to 70 in 1804dbb
This PR implements the existing
skip_libsbehavior by excludingviv_utils.flirt.is_library_function()matches fromget_max_calls_to()whenskip_libs=True.CallsToscoring depends on this value infloss/features/features.py. Before this change, library functions were still included in the max-xref normalization baseline even though the API exposed askip_libsoption. That could compressCallsToscores for real candidate functions in binaries with heavily referenced library/runtime code.This makes the
CallsToheuristic consistent with its function signature and improves normalization quality. In practice, decoder candidates are less likely to be unfairly down-ranked by high-fan-in library functions.AI Disclaimer: GPT 5.4 (in Codex) was used to write local test scripts and for researching on the issue.