Skip to content

Provide an option to install right click menu option for Windows - #970

Merged
mr-tz merged 5 commits into
mandiant:masterfrom
lyc8503:master
Mar 22, 2024
Merged

mr-tz merged 5 commits into
mandiant:masterfrom
lyc8503:master

Conversation

@lyc8503

@lyc8503 lyc8503 commented Mar 14, 2024

Copy link
Copy Markdown
Contributor

This implements #745.

Implemented two options for installing and uninstalling the Windows context menu and tested them on Windows.

By the way, I've also added a hint to upgrade pip and setuptools in the documentation (PEP660 has only been implemented in newer versions of setuptools)

@google-cla

google-cla Bot commented Mar 14, 2024

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Comment thread floss/main.py Resolved
Comment thread doc/installation.md Resolved
Comment thread floss/utils.py Resolved
@mr-tz

mr-tz commented Mar 16, 2024

Copy link
Copy Markdown
Collaborator

This looks great. I will test it next week and let you know if there's any other changes needed. Thank you very much!

Comment thread floss/main.py Resolved
Comment thread floss/utils.py Resolved
Comment thread floss/utils.py Resolved
Comment thread floss/utils.py Resolved

@mr-tz mr-tz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you very much. I like this solution and if people have issues given the various installation methods, we can fix this.

Only thing left to do is a small entry in the documentation at https://github.com/mandiant/flare-floss/blob/master/doc/usage.md. Can you add this, please?

@lyc8503

lyc8503 commented Mar 21, 2024

Copy link
Copy Markdown
Contributor Author

Hi, I have updated the document, and thanks for your code review and feedback too. πŸ˜ƒ

@mr-tz mr-tz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, thanks a lot!

@mr-tz
mr-tz merged commit 01a0a69 into mandiant:master Mar 22, 2024
This was referenced Apr 12, 2024
vee1e pushed a commit to vee1e/flare-floss that referenced this pull request May 29, 2026
Provide an option to install right click menu option for Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants