Repository navigation
Provide an option to install right click menu option for Windows - #970
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
This looks great. I will test it next week and let you know if there's any other changes needed. Thank you very much! |
mr-tz
left a comment
There was a problem hiding this comment.
Awesome, thank you very much. I like this solution and if people have issues given the various installation methods, we can fix this.
Only thing left to do is a small entry in the documentation at https://github.com/mandiant/flare-floss/blob/master/doc/usage.md. Can you add this, please?
|
Hi, I have updated the document, and thanks for your code review and feedback too. π |
mr-tz
left a comment
There was a problem hiding this comment.
great work, thanks a lot!
Provide an option to install right click menu option for Windows
This implements #745.
Implemented two options for installing and uninstalling the Windows context menu and tested them on Windows.
By the way, I've also added a hint to upgrade pip and setuptools in the documentation (PEP660 has only been implemented in newer versions of setuptools)