Repository navigation
Drop a value rejected by @validates from valid_data when the field has an attribute - #3088
Open
andrewstellman wants to merge 2 commits into
Open
andrewstellman wants to merge 2 commits into
andrewstellman wants to merge 2 commits into
Conversation
A field with attribute="a.b" is loaded into a nested dict by set_value, but _invoke_field_validators looked the value up with the literal attribute string, got a KeyError and skipped the validator. Read the value along the dotted path instead.
…s an attribute When a @validates method rejects a field's value, _invoke_field_validators popped the value from the loaded data by field name, but the loaded data is keyed by the field's attribute. For a field with attribute set, the rejected value stayed in ValidationError.valid_data. Pop it by attribute, following a dotted attribute into the nested dict.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a
@validatesmethod rejects the value of a field that hasattributeset, the rejected value stays inValidationError.valid_data:_invoke_field_validatorspopped the rejected value by field name, but the loaded data is keyed by attribute. It now pops by attribute, following a dotted attribute into the nested dict. The test is intests/test_decorators.py.This builds on #3087, which makes validators run for dotted attributes, so that one should go in first.
Found with the Quality Playbook, an AI code-review tool I maintain; I reproduced it and reviewed the fix myself.