Skip to content

Add support for strong reference to TimeGauge - #2136

Merged
jkschneider merged 1 commit into
micrometer-metrics:masterfrom
izeye:time-gauge-strong-reference
Feb 3, 2021
Merged

jkschneider merged 1 commit into
micrometer-metrics:masterfrom
izeye:time-gauge-strong-reference

Conversation

@izeye

@izeye izeye commented Jun 3, 2020

Copy link
Copy Markdown
Contributor

This PR adds support for strong reference to TimeGauge similar to Gauge.

This PR also changes to use it in NewRelicMeterRegistryTest as it seems to be useful for the changes made in #2135.

@jkschneider jkschneider added this to the 1.7.0 milestone Feb 3, 2021
This commit also changes to use it in NewRelicMeterRegistryTest.
@izeye
izeye force-pushed the time-gauge-strong-reference branch from 4d873d0 to 480f9df Compare February 3, 2021 19:07
@izeye

izeye commented Feb 3, 2021

Copy link
Copy Markdown
Contributor Author

I rebased this onto the current master branch to resolve the conflicts and updated Javadoc @since tag and @Incubating since attribute to be 1.7.0 as @jkschneider has assigned it to the 1.7.0 milestone.

@jkschneider
jkschneider merged commit 7ea1eb3 into micrometer-metrics:master Feb 3, 2021
@izeye
izeye deleted the time-gauge-strong-reference branch February 3, 2021 22:05
@shakuzen shakuzen added the enhancement A general enhancement label Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants