Repository navigation
Declare HdrHistogram as a runtime dependency - #3263
Merged
shakuzen merged 1 commit intoAug 3, 2022
Merged
Conversation
HdrHistogram is not exposed in the API. It is an implementation detail of client-side percentiles. The scope of the dependency can be changed accordingly.
Member
Author
|
I may have been too eager with this change. HdrHistogram's Though I'm not sure if that is a problem for changing the scope here or not. Outside of the local package, I don't think there is reference to any HdrHistogram classes in API that users would be able to compile against. |
jonatan-ivanov
approved these changes
Jul 11, 2022
Member
Author
|
With #3325 in now, I think we can give this a try in 1.10. User code should not compile against Micrometer API that has the HdrHistogram API in it with normal usage that I can think of. If client-side percentiles are being used, HdrHistogram is still needed at runtime. This pull request still declares HdrHistogram as needed at runtime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HdrHistogram is not exposed in the API. It is an implementation detail of client-side percentiles. The scope of the dependency can be changed accordingly.
This was found while working on #1599.